Merge pull request #18324 from mozilla/FXA-11059

fix(settings): Clear error messages on submit SigninTokenCode/ConfirmSignupCode

Author: vpomerleau

packages/fxa-settings/src/pages/Signin/SigninTokenCode/index.tsx

@@ -119,8 +119,14 @@ const SigninTokenCode = ({
     }
   };
 
+  const clearErrorMessages = () => {
+    setLocalizedErrorBannerMessage('');
+    setCodeErrorMessage('');
+  };
+
   const onSubmit = useCallback(
     async (code: string) => {
+      clearErrorMessages();
       if (!SIX_DIGIT_NUMBER_REGEX.test(code)) {
         setCodeErrorMessage(localizedInvalidCode);
         return;

packages/fxa-settings/src/pages/Signup/ConfirmSignupCode/index.tsx

@@ -114,7 +114,13 @@ const ConfirmSignupCode = ({
     }
   }
 
+  function clearErrorMessages() {
+    setLocalizedErrorBannerHeading('');
+    setCodeErrorMessage('');
+  }
+
   async function verifySession(code: string) {
+    clearErrorMessages();
     logViewEvent(`flow.${viewName}`, 'submit', REACT_ENTRYPOINT);
     GleanMetrics.signupConfirmation.submit();
     try {