polish(shared/sentry): Fix duplicate typedef for SentryConfigOpts

Author: dschom

libs/shared/sentry-utils/src/lib/models/sentry-config-opts.ts

@@ -29,6 +29,12 @@ export type SentryConfigOpts = {
 
     /** The tracing sample rate. Setting this above 0 will aso result in performance metrics being captured. */
     tracesSampleRate?: number;
+
+    /** A function that determines the sample rate for a given event. Setting this will override tracesSampleRate. */
+    tracesSampler?: (context: { name?: string }) => number;
+
+    /** A list of errors to ignore. Can be strings, regexes, or functions that take an error and return a boolean. */
+    ignoreErrors?: Array<string | RegExp>;
   };
 };
 

libs/shared/sentry/src/lib/browser.spec.ts

@@ -4,7 +4,7 @@
 import 'jsdom-global/register';
 import * as Sentry from '@sentry/browser';
 import * as sentryWrapper from './browser';
-import { SentryConfigOpts } from './models/SentryConfigOpts';
+import { SentryConfigOpts } from '@fxa/shared/sentry-utils';
 
 jest.mock('@sentry/browser', () => {
   const actual = jest.requireActual('@sentry/browser');

libs/shared/sentry/src/lib/browser.ts

@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import * as Sentry from '@sentry/browser';
-import { SentryConfigOpts } from './models/SentryConfigOpts';
+import { SentryConfigOpts } from '@fxa/shared/sentry-utils';
 import { tagFxaName } from './reporting';
 import { buildSentryConfig } from './config-builder';
 import { Logger } from './sentry.types';

libs/shared/sentry/src/lib/config-builder.spec.ts

@@ -2,7 +2,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 import { buildSentryConfig } from './config-builder';
-import { SentryConfigOpts } from './models/SentryConfigOpts';
+import { SentryConfigOpts } from '@fxa/shared/sentry-utils';
 import { Logger } from './sentry.types';
 
 describe('config-builder', () => {

libs/shared/sentry/src/lib/config-builder.ts

@@ -2,7 +2,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 import { Logger } from './sentry.types';
-import { SentryConfigOpts } from './models/SentryConfigOpts';
+import { SentryConfigOpts } from '@fxa/shared/sentry-utils';
 
 const sentryEnvMap: Record<string, string> = {
   test: 'test',
@@ -37,7 +37,6 @@ export function buildSentryConfig(config: SentryConfigOpts, log: Logger) {
     fxaName: config.sentry?.clientName || config.sentry?.serverName,
     tracesSampleRate: config.sentry?.tracesSampleRate,
     ignoreErrors: config.sentry?.ignoreErrors || [],
-    sendDefaultPii: config.sentry?.sendDefaultPii ?? true,
   };
 
   return opts;

libs/shared/sentry/src/lib/next/client.ts

@@ -7,7 +7,7 @@
 // https://docs.sentry.io/platforms/javascript/guides/nextjs/
 
 import * as Sentry from '@sentry/nextjs';
-import { SentryConfigOpts } from '../models/SentryConfigOpts';
+import { SentryConfigOpts } from '@fxa/shared/sentry-utils';
 import { buildSentryConfig } from '../config-builder';
 import { Logger } from '../sentry.types';
 import { beforeSend } from '../utils/beforeSend.client';

libs/shared/sentry/src/lib/next/server.ts

@@ -4,7 +4,7 @@
 
 import * as Sentry from '@sentry/nextjs';
 import { ErrorEvent } from '@sentry/core';
-import { InitSentryOpts } from '../models/SentryConfigOpts';
+import { InitSentryOpts } from '@fxa/shared/sentry-utils';
 import { buildSentryConfig } from '../config-builder';
 import { Logger } from '../sentry.types';
 import { beforeSend } from '../utils/beforeSend.server';

libs/shared/sentry/src/lib/node.ts

@@ -5,7 +5,7 @@
 import * as Sentry from '@sentry/node';
 import { ErrorEvent } from '@sentry/core';
 import { extraErrorDataIntegration } from '@sentry/node';
-import { SentryConfigOpts } from './models/SentryConfigOpts';
+import { SentryConfigOpts } from '@fxa/shared/sentry-utils';
 import { buildSentryConfig } from './config-builder';
 import { tagFxaName } from './reporting';
 import { Logger } from './sentry.types';

libs/shared/sentry/src/lib/utils/beforeSend.client.spec.ts

@@ -2,7 +2,7 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-import { SentryConfigOpts } from '../models/SentryConfigOpts';
+import { SentryConfigOpts } from '@fxa/shared/sentry-utils';
 import { beforeSend } from './beforeSend.client';
 import * as Sentry from '@sentry/nextjs';
 

libs/shared/sentry/src/lib/utils/beforeSend.client.ts

@@ -4,7 +4,7 @@
 
 // Change to @sentry/browser after upgrade to Sentry 8
 import * as Sentry from '@sentry/nextjs';
-import { SentryConfigOpts } from '../models/SentryConfigOpts';
+import { SentryConfigOpts } from '@fxa/shared/sentry-utils';
 import { tagFxaName } from './tagFxaName';
 
 /**