Merge pull request #18384 from mozilla/FXA-11151

fix(auth): SMS message did not include body text

Author: vpomerleau

packages/fxa-auth-server/lib/routes/recovery-phone.ts

@@ -60,7 +60,7 @@ class RecoveryPhoneHandler {
     this.localizer = new Localizer(new NodeRendererBindings());
   }
 
-  getLocalizedStrings = async (
+  getLocalizedMessage = async (
     request: AuthRequest,
     code: string,
     type: 'setup' | 'signin'
@@ -85,7 +85,7 @@ class RecoveryPhoneHandler {
         },
       ]
     );
-    return localizedStrings;
+    return localizedStrings[id];
   };
 
   async sendCode(request: AuthRequest) {
@@ -102,11 +102,11 @@ class RecoveryPhoneHandler {
     await this.customs.check(request, email, 'recoveryPhoneSendCode');
 
     const getFormattedMessage = async (code: string) => {
-      const localizedMessage = await this.getLocalizedStrings(
+      const localizedMessage = await this.getLocalizedMessage(
         request,
         code,
         'signin'
-      )[0];
+      );
       return localizedMessage;
     };
 
@@ -169,11 +169,11 @@ class RecoveryPhoneHandler {
     await this.customs.checkAuthenticated(request, uid, 'recoveryPhoneCreate');
 
     const getFormattedMessage = async (code: string) => {
-      const localizedMessage = await this.getLocalizedStrings(
+      const localizedMessage = await this.getLocalizedMessage(
         request,
         code,
         'setup'
-      )[0];
+      );
       return localizedMessage;
     };
 
@@ -498,7 +498,7 @@ class RecoveryPhoneHandler {
     } catch (error) {
       throw AppError.backendServiceFailure(
         'RecoveryPhoneService',
-        'destroy',
+        'available',
         { uid },
         error
       );