Skip to content

Commit e012c13

Browse files
fix(admin): fix email bounce type display
Because: * email bounce types are shown as enum integers instead of strings This commit: * make the backend endpoint return transformed strings dirrectly. Closes FXA-13417
1 parent 21706ba commit e012c13

1 file changed

Lines changed: 11 additions & 1 deletion

File tree

packages/fxa-admin-server/src/rest/account/account.controller.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ import {
5353
EventNames,
5454
} from '../../event-logging/event-logging.service';
5555
import { AccountEvent as AccountEventType } from '../model/account-events.model';
56+
import { BounceType, BounceSubType } from '../model/email-bounces.model';
5657
import { BasketService } from '../../newsletters/basket.service';
5758
import { FidoMdsService } from '../../backend/fido-mds.service';
5859
import { SubscriptionsService } from '../../subscriptions/subscriptions.service';
@@ -750,6 +751,7 @@ export class AccountController {
750751

751752
// ─── Field resolver helpers (public so integration tests can call them) ───
752753

754+
@Features(AdminPanelFeature.AccountSearch)
753755
public async emailBounces(account: Account) {
754756
const uidBuffer = uuidTransformer.to(account.uid);
755757
const emails = await this.db.emails
@@ -765,7 +767,14 @@ export class AccountController {
765767
'in',
766768
emails.map((x) => x.normalizedEmail)
767769
);
768-
return result;
770+
return result.map((bounce) => ({
771+
...bounce,
772+
bounceType:
773+
BounceType[bounce.bounceType] ?? BounceType[BounceType.unmapped],
774+
bounceSubType:
775+
BounceSubType[bounce.bounceSubType] ??
776+
BounceSubType[BounceSubType.unmapped],
777+
}));
769778
}
770779

771780
@Features(AdminPanelFeature.AccountSearch)
@@ -869,6 +878,7 @@ export class AccountController {
869878
];
870879
}
871880

881+
@Features(AdminPanelFeature.AccountSearch)
872882
public async linkedAccounts(account: Account) {
873883
const uidBuffer = uuidTransformer.to(account.uid);
874884
return await this.db.linkedAccounts

0 commit comments

Comments
 (0)