Skip to content

Commit de0204e

Browse files
fix(storybook): fix local storybooks not localized
Because: * localhost storybooks aren't localized This Commit: * fixes this bug by correcting the baseDir url Closes: FXA-10885
1 parent 6703724 commit de0204e

8 files changed

Lines changed: 13 additions & 49 deletions

File tree

packages/fxa-react/components/AppErrorDialog/index.stories.tsx

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,26 +9,17 @@ import AppLocalizationProvider from '../../lib/AppLocalizationProvider';
99

1010
storiesOf('Components/AppErrorDialog', module)
1111
.add('basic', () => (
12-
<AppLocalizationProvider
13-
baseDir="./locales"
14-
userLocales={navigator.languages}
15-
>
12+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
1613
<AppErrorDialog />
1714
</AppLocalizationProvider>
1815
))
1916
.add('general with errors', () => (
20-
<AppLocalizationProvider
21-
baseDir="./locales"
22-
userLocales={navigator.languages}
23-
>
17+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
2418
<AppErrorDialog errorType="general" />
2519
</AppLocalizationProvider>
2620
))
2721
.add('invalid query parameters', () => (
28-
<AppLocalizationProvider
29-
baseDir="./locales"
30-
userLocales={navigator.languages}
31-
>
22+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
3223
<AppErrorDialog errorType="query-parameter-violation" />
3324
</AppLocalizationProvider>
3425
));

packages/fxa-react/components/Footer/index.stories.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,7 @@ import { Footer } from './index';
88
import AppLocalizationProvider from '../../lib/AppLocalizationProvider';
99

1010
storiesOf('Components/Footer', module).add('default', () => (
11-
<AppLocalizationProvider
12-
baseDir="./locales"
13-
userLocales={navigator.languages}
14-
>
11+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
1512
<Footer />
1613
</AppLocalizationProvider>
1714
));

packages/fxa-react/components/Header/index.stories.tsx

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,12 @@ import AppLocalizationProvider from '../../lib/AppLocalizationProvider';
99

1010
storiesOf('Components/Header', module)
1111
.add('basic', () => (
12-
<AppLocalizationProvider
13-
baseDir="./locales"
14-
userLocales={navigator.languages}
15-
>
12+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
1613
<Header left={<div>left content</div>} right={<div>right content</div>} />
1714
</AppLocalizationProvider>
1815
))
1916
.add('with LogoLockup', () => (
20-
<AppLocalizationProvider
21-
baseDir="./locales"
22-
userLocales={navigator.languages}
23-
>
17+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
2418
<Header
2519
left={<LogoLockup>Some title</LogoLockup>}
2620
right={<div>right content</div>}

packages/fxa-react/components/LinkExternal/index.stories.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ import LinkExternal from './index';
77
import AppLocalizationProvider from '../../lib/AppLocalizationProvider';
88

99
storiesOf('Components/LinkExternal', module).add('basic', () => (
10-
<AppLocalizationProvider
11-
baseDir="./locales"
12-
userLocales={navigator.languages}
13-
>
10+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
1411
<LinkExternal href="https://mozilla.org">
1512
Keep the internet open and accessible to all.
1613
</LinkExternal>

packages/fxa-react/components/LoadingSpinner/index.stories.tsx

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,17 @@ import AppLocalizationProvider from '../../lib/AppLocalizationProvider';
88

99
storiesOf('Components/LoadingSpinner', module)
1010
.add('default', () => (
11-
<AppLocalizationProvider
12-
baseDir="./locales"
13-
userLocales={navigator.languages}
14-
>
11+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
1512
<LoadingSpinner />
1613
</AppLocalizationProvider>
1714
))
1815
.add('blue', () => (
19-
<AppLocalizationProvider
20-
baseDir="./locales"
21-
userLocales={navigator.languages}
22-
>
16+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
2317
<LoadingSpinner spinnerType={SpinnerType.Blue} />
2418
</AppLocalizationProvider>
2519
))
2620
.add('white', () => (
27-
<AppLocalizationProvider
28-
baseDir="./locales"
29-
userLocales={navigator.languages}
30-
>
21+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
3122
<div className="bg-grey-700">
3223
<LoadingSpinner spinnerType={SpinnerType.White} />
3324
</div>

packages/fxa-react/lib/storybooks.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ import {
1515
// If a localized string is available, that will be rendered in the storybook,
1616
// otherwise the fallback strings will be displayed.
1717
export const withLocalization: Decorator = (Story) => (
18-
<AppLocalizationProvider
19-
baseDir="./locales"
20-
userLocales={navigator.languages}
21-
>
18+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
2219
<Story />
2320
</AppLocalizationProvider>
2421
);

packages/fxa-settings/src/components/CardLoadingSpinner/index.stories.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ import AppLocalizationProvider from 'fxa-react/lib/AppLocalizationProvider';
1010

1111
storiesOf('Components/CardLoadingSpinner', module)
1212
.addDecorator((story) => (
13-
<AppLocalizationProvider
14-
baseDir="./locales"
15-
userLocales={navigator.languages}
16-
>
13+
<AppLocalizationProvider baseDir="." userLocales={navigator.languages}>
1714
{story()}
1815
</AppLocalizationProvider>
1916
))

packages/fxa-settings/src/lib/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export function getDefault() {
118118
env: 'development',
119119
l10n: {
120120
strict: false,
121-
baseUrl: '/settings/locales',
121+
baseUrl: '/settings/static',
122122
},
123123
marketingEmailPreferencesUrl: 'https://basket.mozilla.org/fxa/',
124124
metrics: {

0 commit comments

Comments
 (0)