refactor(signup): use auth-client directly for signup instead of gql

Author: vbudhram

packages/fxa-graphql-api/src/gql/account.resolver.spec.ts

@@ -701,77 +701,6 @@ describe('#integration - AccountResolver', () => {
       });
     });
 
-    describe('signUp', () => {
-      it('calls auth-client and proxy the result', async () => {
-        const now = Date.now();
-        const mockRespPayload = {
-          clientMutationId: 'testid',
-          uid: '1337',
-          sessionToken: '2048',
-          sessionVerified: true,
-          authAt: now,
-        };
-        authClient.signUpWithAuthPW = jest
-          .fn()
-          .mockResolvedValue(mockRespPayload);
-        const result = await resolver.signUp(headers, {
-          authPW: '00000000',
-          email: '[email protected]',
-          options: { service: 'testo-co' },
-        });
-        expect(authClient.signUpWithAuthPW).toBeCalledTimes(1);
-        expect(authClient.signUpWithAuthPW).toBeCalledWith(
-          '[email protected]',
-          '00000000',
-          {},
-          { service: 'testo-co' },
-          headers
-        );
-        expect(result).toStrictEqual(mockRespPayload);
-      });
-
-      it('calls auth-client and proxy the result with V2 password', async () => {
-        const now = Date.now();
-        const mockRespPayload = {
-          clientMutationId: 'testid',
-          uid: '1337',
-          sessionToken: '2048',
-          sessionVerified: true,
-          authAt: now,
-        };
-        authClient.signUpWithAuthPW = jest
-          .fn()
-          .mockResolvedValue(mockRespPayload);
-        const result = await resolver.signUp(headers, {
-          authPW: '00000000',
-          email: '[email protected]',
-          passwordV2: {
-            wrapKb: '1234'.repeat(8),
-            authPWVersion2: '1234'.repeat(8),
-            wrapKbVersion2: '1234'.repeat(8),
-            clientSalt:
-              'identity.mozilla.com/picl/v1/quickStretchV2:0123456789abcdef0123456789abcdef',
-          },
-          options: { service: 'testo-co' },
-        });
-        expect(authClient.signUpWithAuthPW).toBeCalledTimes(1);
-        expect(authClient.signUpWithAuthPW).toBeCalledWith(
-          '[email protected]',
-          '00000000',
-          {
-            wrapKb: '1234'.repeat(8),
-            authPWVersion2: '1234'.repeat(8),
-            wrapKbVersion2: '1234'.repeat(8),
-            clientSalt:
-              'identity.mozilla.com/picl/v1/quickStretchV2:0123456789abcdef0123456789abcdef',
-          },
-          { service: 'testo-co' },
-          headers
-        );
-        expect(result).toStrictEqual(mockRespPayload);
-      });
-    });
-
     describe('finishSetup', () => {
       it('calls auth-client and proxy the result', async () => {
         const mockRespPayload = {

packages/fxa-graphql-api/src/gql/account.resolver.ts

@@ -63,7 +63,6 @@ import { DeleteAvatarInput } from './dto/input/delete-avatar';
 import { MetricsOptInput } from './dto/input/metrics-opt';
 import { RejectUnblockCodeInput } from './dto/input/reject-unblock-code';
 import { SignInInput } from './dto/input/sign-in';
-import { SignUpInput } from './dto/input/sign-up';
 import {
   AccountResetPayload,
   AccountStatusPayload,
@@ -83,7 +82,6 @@ import {
   WrappedKeysPayload,
 } from './dto/payload';
 import { SignedInAccountPayload } from './dto/payload/signed-in-account';
-import { SignedUpAccountPayload } from './dto/payload/signed-up-account';
 import { CatchGatewayError } from './lib/error';
 import { Account as AccountType } from './model/account';
 import { uuidTransformer } from 'fxa-shared/db/transformers';
@@ -585,28 +583,6 @@ export class AccountResolver {
     };
   }
 
-  @Mutation((returns) => SignedUpAccountPayload, {
-    description: 'Call auth-server to sign up an account',
-  })
-  @CatchGatewayError
-  public async signUp(
-    @GqlXHeaders() headers: Headers,
-    @Args('input', { type: () => SignUpInput })
-    input: SignUpInput
-  ): Promise<SignedUpAccountPayload> {
-    const result = await this.authAPI.signUpWithAuthPW(
-      input.email,
-      input.authPW,
-      input.passwordV2 || {},
-      input.options,
-      headers
-    );
-    return {
-      clientMutationId: input.clientMutationId,
-      ...result,
-    };
-  }
-
   @Mutation((returns) => FinishedSetupAccountPayload, {
     description: 'Call auth-server to finish signing up a "stub" account',
   })