Skip to content

Commit dae2972

Browse files
committed
fix(shared/sentry-utils): Break circular import in before-send.browser
Because: - before-send.browser.ts imported SentryConfigOpts and tagFxaName from '@fxa/shared/sentry-utils' (its own index). Webpack's circular-module handling left the re-exported bindings undefined in the content-server test bundle, which caused the mocha runner to never initialize (the 'globalThis.runner is undefined' failure surfaced by the functional tests for content-server mocha tests, cookies disabled, and post-verify force password change). This commit: - Imports SentryConfigOpts directly from ./models/sentry-config-opts and tagFxaName directly from ./utils.
1 parent c40d452 commit dae2972

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

libs/shared/sentry-utils/src/lib/before-send.browser.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { ErrorEvent, EventHint } from '@sentry/core';
2-
import { SentryConfigOpts, tagFxaName } from '@fxa/shared/sentry-utils';
2+
import { SentryConfigOpts } from './models/sentry-config-opts';
3+
import { tagFxaName } from './utils';
34

45
// Internal flag to keep track of whether or not sentry is initialized
56
let sentryEnabled = false;

0 commit comments

Comments
 (0)