Skip to content

Commit c214e87

Browse files
committed
chore(admin): Delete unused code from fxa-shared
Because: - Cleaning up code duplication, in favor of code ported to libs This Commit: - Deletes unreferenced code
1 parent cd7fedc commit c214e87

31 files changed

Lines changed: 3 additions & 3005 deletions

packages/fxa-shared/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,15 +93,15 @@ Or by building up the new set in place:
9393

9494
This utility allows for easy configuration of tracing. To use this in a service:
9595

96-
- Add the config chunk in fxa-shared/tracing/config to your packages's config.
96+
- Add the config chunk in @fxa/shared/otel to your packages's config.
9797

9898
- Then initialize as follows. This invocation should happen as early as possible in the service's or app's lifecycle. Ideally it's
9999
the first thing done, even before importing other modules.
100100

101101
```
102102
// For services
103103
const config = require('../config');
104-
require('fxa-shared/tracing/node-tracing').initTracing(config.get('tracing'));
104+
require('@fxa/shared/otel').initTracing(config.get('tracing'));
105105
```
106106

107107
To see traces on your local system, set the following environment variables:
@@ -122,7 +122,7 @@ TRACING_OTEL_COLLECTOR_JAEGER_ENABLED=true
122122
123123
```
124124

125-
The default config for tracing found at fxa-shared/tracing/config.ts will pick up these variables and result in traces showing up in Jaeger which runs locally at `localhost:16686`.
125+
The default config for tracing found at @fxa/shared/otel will pick up these variables and result in traces showing up in Jaeger which runs locally at `localhost:16686`.
126126

127127
It's important to note that sentry also supports tracing integration. So we typically let a call to 'initSentry', a function located in the sentry/node.ts module do the work of initializing tracing.
128128

packages/fxa-shared/monitoring/index.ts

Lines changed: 0 additions & 37 deletions
This file was deleted.

packages/fxa-shared/package.json

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,6 @@
121121
"import": "./dist/esm/packages/fxa-shared/log/*.js",
122122
"require": "./dist/cjs/packages/fxa-shared/log/*.js"
123123
},
124-
"./monitoring": {
125-
"import": "./dist/esm/packages/fxa-shared/monitoring/index.js",
126-
"require": "./dist/cjs/packages/fxa-shared/monitoring/index.js"
127-
},
128124
"./metrics/*": {
129125
"import": "./dist/esm/packages/fxa-shared/metrics/*.js",
130126
"require": "./dist/cjs/packages/fxa-shared/metrics/*.js"
@@ -169,14 +165,6 @@
169165
"import": "./dist/esm/packages/fxa-shared/scripts/*.js",
170166
"require": "./dist/cjs/packages/fxa-shared/scripts/*.js"
171167
},
172-
"./sentry": {
173-
"import": "./dist/esm/packages/fxa-shared/sentry/index.js",
174-
"require": "./dist/cjs/packages/fxa-shared/sentry/index.js"
175-
},
176-
"./sentry/*": {
177-
"import": "./dist/esm/packages/fxa-shared/sentry/*.js",
178-
"require": "./dist/cjs/packages/fxa-shared/sentry/*.js"
179-
},
180168
"./speed-trap/*": {
181169
"import": "./dist/esm/packages/fxa-shared/speed-trap/*.js",
182170
"require": "./dist/cjs/packages/fxa-shared/speed-trap/*.js"
@@ -185,10 +173,6 @@
185173
"import": "./dist/esm/packages/fxa-shared/subscriptions/*.js",
186174
"require": "./dist/cjs/packages/fxa-shared/subscriptions/*.js"
187175
},
188-
"./tracing/*": {
189-
"import": "./dist/esm/packages/fxa-shared/tracing/*.js",
190-
"require": "./dist/cjs/packages/fxa-shared/tracing/*.js"
191-
},
192176
"./test/db/models/auth/*": {
193177
"import": "./dist/esm/packages/fxa-shared/test/db/models/auth/*.js",
194178
"require": "./dist/cjs/packages/fxa-shared/test/db/models/auth/*.js"

packages/fxa-shared/sentry/browser.ts

Lines changed: 0 additions & 136 deletions
This file was deleted.

packages/fxa-shared/sentry/config-builder.ts

Lines changed: 0 additions & 88 deletions
This file was deleted.

packages/fxa-shared/sentry/index.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/fxa-shared/sentry/joi-message-overrides.ts

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)