feat(auth): disable duplicate upgrade email, remove stub account email

Because:

- We do not use stub accounts for subplat anymore
- We already send an upgrade email

This commit:

- Disables the duplicate upgrade email
- Removes the stub account email logic

Closes PAY-2290

Author: julianpoy

libs/accounts/email-renderer/src/renderer/subplat-email-renderer.ts

@@ -3,7 +3,6 @@ import * as SubscriptionLayouts from '../layouts/subscription';
 import * as DownloadSubscription from '../templates/downloadSubscription';
 import * as FraudulentAccountDeletion from '../templates/fraudulentAccountDeletion';
 import * as SubscriptionAccountDeletion from '../templates/subscriptionAccountDeletion';
-import * as SubscriptionAccountFinishSetup from '../templates/subscriptionAccountFinishSetup';
 import * as SubscriptionAccountReminderFirst from '../templates/subscriptionAccountReminderFirst';
 import * as SubscriptionAccountReminderSecond from '../templates/subscriptionAccountReminderSecond';
 import * as SubscriptionCancellation from '../templates/subscriptionCancellation';
@@ -64,20 +63,6 @@ export class SubplatEmailRender extends EmailRenderer {
     });
   }
 
-  async renderSubscriptionAccountFinishSetup(
-    templateValues: SubscriptionAccountFinishSetup.TemplateData,
-    layoutTemplateValues: SubscriptionLayouts.TemplateData
-  ) {
-    return this.renderEmail({
-      template: SubscriptionAccountFinishSetup.template,
-      version: SubscriptionAccountFinishSetup.version,
-      layout: SubscriptionAccountFinishSetup.layout,
-      includes: SubscriptionAccountFinishSetup.includes,
-      ...templateValues,
-      ...layoutTemplateValues,
-    });
-  }
-
   async renderSubscriptionAccountReminderFirst(
     templateValues: SubscriptionAccountReminderFirst.TemplateData,
     layoutTemplateValues: SubscriptionLayouts.TemplateData

libs/accounts/email-renderer/src/templates/subscriptionAccountFinishSetup/en.ftl

@@ -925,7 +925,6 @@ const conf = convict({
         'verifyLogin',
         'recovery',
         'unblockCode',
-        'subscriptionAccountFinishSetup',
       ],
       env: 'BOUNCES_IGNORE_TEMPLATES',
     },

libs/accounts/email-renderer/src/templates/subscriptionAccountFinishSetup/includes.json

@@ -602,7 +602,6 @@ const convictConf = convict({
           'verifyLogin',
           'recovery',
           'unblockCode',
-          'subscriptionAccountFinishSetup',
         ],
         env: 'BOUNCES_IGNORE_TEMPLATES',
       },

libs/accounts/email-renderer/src/templates/subscriptionAccountFinishSetup/index.mjml

@@ -23,7 +23,6 @@ const { version: VERSION } = require('../../package.json');
 
 // Maps template name to email type
 const EMAIL_TYPES = {
-  subscriptionAccountFinishSetup: 'subscription_account_finish_setup',
   subscriptionAccountReminderFirst: 'subscription_account_finish_setup',
   subscriptionAccountReminderSecond: 'subscription_account_finish_setup',
   subscriptionReactivation: 'subscription_reactivation',