Skip to content

Commit b291d3a

Browse files
authored
Merge pull request #18257 from mozilla/FXA-9872
chore(dev-launcher) - Change the default context to oauth_webchannel_v1
2 parents 0a311ef + 192aabe commit b291d3a

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/fxa-dev-launcher/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Available options:
1111
- `FIREFOX_DEBUGGER=true` - open the [Browser Toolbox](https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox) on start (NOTE: `false` by default for speed).
1212
- `FXA_DESKTOP_CONTEXT` - context value for the fxa-content-server: `context=[value]` (NOTE: `fx_desktop_v3` is default).
1313

14-
Tip: run `FXA_DESKTOP_CONTEXT=oauth_webchannel_v1 yarn firefox` (from the repo root) to test the OAuth Desktop flow. Run `FXA_DESKTOP_CONTEXT=oauth_webchannel_v1 FIREFOX_BIN=/Applications/Firefox\ Nightly.app/Contents/MacOS/firefox yarn firefox` to test the OAuth Desktop flow (for MacOS) on Nightly.
14+
Tip: run `FXA_DESKTOP_CONTEXT=fx_desktop_v3 yarn firefox` (from the repo root) to test the old Desktop flow (supported until ESR 140). Run `FXA_DESKTOP_CONTEXT=fx_desktop_v3 FIREFOX_BIN=/Applications/Firefox\ Nightly.app/Contents/MacOS/firefox yarn firefox` to test the Desktop flow (for MacOS) on Nightly.
1515

1616
### Basic Usage Example in OS X
1717

packages/fxa-dev-launcher/profile.mjs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const CONFIGS = {
4747
};
4848

4949
const env = process.env.FXA_ENV || 'local';
50-
const FXA_DESKTOP_CONTEXT = process.env.FXA_DESKTOP_CONTEXT || 'fx_desktop_v3';
50+
const FXA_DESKTOP_CONTEXT = process.env.FXA_DESKTOP_CONTEXT || 'oauth_webchannel_v1';
5151
const e10sDisabled = process.env.DISABLE_E10S === 'true';
5252
let fxaEnv = CONFIGS[env];
5353

@@ -115,11 +115,11 @@ const fxaProfile = {
115115
// allow webchannel url, strips slash from content-server origin.
116116
'webchannel.allowObject.urlWhitelist': fxaEnv.content.slice(0, -1),
117117
'browser.tabs.firefox-view': true,
118+
// TODO in FXA-11026, see if we still need the other prefs since we only need
119+
// to use the autoconfig to get everything else set. See: bug 1942925.
118120
'identity.fxaccounts.autoconfig.uri': fxaEnv.content,
119121
// disable password auto-fill; we typically don't need to test this daily.
120122
'signon.rememberSignons': false,
121-
// TODO in FXA-9872, make oauth_webchannel_v1 the default context and
122-
// change these values for fx_desktop_v3. (Also, update the README note)
123123
...(process.env.FXA_DESKTOP_CONTEXT === 'oauth_webchannel_v1' && {
124124
'identity.fxaccounts.oauth.enabled': true,
125125
'identity.fxaccounts.contextParam': 'oauth_webchannel_v1',

0 commit comments

Comments
 (0)