fix(payments): Coupons - Handle error when currency for coupon and cart do not match

Author: xlisachan

libs/payments/cart/src/lib/cart.service.spec.ts

@@ -533,6 +533,9 @@ describe('CartService', () => {
         CartInvalidPromoCodeError
       );
 
+      expect(
+        promotionCodeManager.assertValidPromotionCodeNameForPrice
+      ).toHaveBeenCalledWith(args.promoCode, mockPrice, mockResolvedCurrency);
       expect(cartManager.createCart).not.toHaveBeenCalled();
     });
 
@@ -683,6 +686,13 @@ describe('CartService', () => {
         cartService.restartCart(mockOldCart.id)
       ).rejects.toThrowError(CartInvalidPromoCodeError);
 
+      expect(
+        promotionCodeManager.assertValidPromotionCodeNameForPrice
+      ).toHaveBeenCalledWith(
+        mockOldCart.couponCode,
+        mockPrice,
+        mockOldCart.currency
+      );
       expect(cartManager.createCart).not.toHaveBeenCalled();
       expect(cartManager.finishErrorCart).toHaveBeenCalled();
     });
@@ -998,6 +1008,13 @@ describe('CartService', () => {
           cartService.updateCart(mockCart.id, mockCart.version, mockUpdateCart)
         ).rejects.toBeInstanceOf(CouponErrorExpired);
 
+        expect(
+          promotionCodeManager.assertValidPromotionCodeNameForPrice
+        ).toHaveBeenCalledWith(
+          mockUpdateCart.couponCode,
+          mockPrice,
+          mockUpdateCart.currency
+        );
         expect(cartManager.updateFreshCart).not.toHaveBeenCalledWith();
         expect(cartManager.finishErrorCart).toHaveBeenCalled();
       });

libs/payments/cart/src/lib/cart.service.ts

@@ -262,7 +262,8 @@ export class CartService {
       try {
         await this.promotionCodeManager.assertValidPromotionCodeNameForPrice(
           args.promoCode,
-          price
+          price,
+          currency
         );
       } catch (e) {
         throw new CartInvalidPromoCodeError(args.promoCode);
@@ -318,7 +319,8 @@ export class CartService {
 
           await this.promotionCodeManager.assertValidPromotionCodeNameForPrice(
             oldCart.couponCode,
-            price
+            price,
+            oldCart.currency || DEFAULT_CURRENCY
           );
         } catch (e) {
           throw new CartInvalidPromoCodeError(oldCart.couponCode);
@@ -491,7 +493,8 @@ export class CartService {
 
         await this.promotionCodeManager.assertValidPromotionCodeNameForPrice(
           cartDetails.couponCode,
-          price
+          price,
+          cartDetails.currency || DEFAULT_CURRENCY
         );
       }
 

libs/payments/cart/src/lib/checkout.service.spec.ts

@@ -304,7 +304,11 @@ describe('CheckoutService', () => {
       it('fetches promotion code by name', async () => {
         expect(
           promotionCodeManager.assertValidPromotionCodeNameForPrice
-        ).toHaveBeenCalledWith(mockCart.couponCode, mockPrice);
+        ).toHaveBeenCalledWith(
+          mockCart.couponCode,
+          mockPrice,
+          mockCart.currency
+        );
       });
     });
 

libs/payments/cart/src/lib/checkout.service.ts

@@ -188,7 +188,8 @@ export class CheckoutService {
       try {
         await this.promotionCodeManager.assertValidPromotionCodeNameForPrice(
           cart.couponCode,
-          price
+          price,
+          cart.currency
         );
 
         promotionCode = await this.promotionCodeManager.retrieveByName(

libs/payments/customer/src/lib/promotionCode.manager.spec.ts

@@ -19,8 +19,12 @@ import {
   StripeSubscriptionFactory,
   StripeSubscriptionItemFactory,
   MockStripeConfigProvider,
+  StripeCouponFactory,
 } from '@fxa/payments/stripe';
-import { PromotionCodeCouldNotBeAttachedError } from './error';
+import {
+  CouponErrorInvalid,
+  PromotionCodeCouldNotBeAttachedError,
+} from './error';
 import { STRIPE_PRICE_METADATA } from './types';
 import { SubscriptionManager } from './subscription.manager';
 
@@ -157,8 +161,13 @@ describe('PromotionCodeManager', () => {
 
   describe('assertValidPromotionCodeNameForPrice', () => {
     it('resolves correctly when valid', async () => {
-      const mockPromotionCode = StripePromotionCodeFactory();
       const mockPrice = StripePriceFactory();
+      const mockPromotionCode = StripePromotionCodeFactory({
+        coupon: StripeCouponFactory({
+          currency: mockPrice.currency,
+        }),
+      });
+      const mockCartCurrency = mockPrice.currency;
 
       jest
         .spyOn(promotionCodeManager, 'retrieveByName')
@@ -170,14 +179,16 @@ describe('PromotionCodeManager', () => {
       await expect(
         promotionCodeManager.assertValidPromotionCodeNameForPrice(
           mockPromotionCode.code,
-          mockPrice
+          mockPrice,
+          mockCartCurrency
         )
       ).resolves.toEqual(undefined);
     });
 
     it('throws an error if promotion code is not found', async () => {
       const mockPromotionCode = StripePromotionCodeFactory();
       const mockPrice = StripePriceFactory();
+      const mockCartCurrency = mockPrice.currency;
 
       jest
         .spyOn(stripeClient, 'promotionCodesList')
@@ -186,14 +197,16 @@ describe('PromotionCodeManager', () => {
       await expect(() =>
         promotionCodeManager.assertValidPromotionCodeNameForPrice(
           mockPromotionCode.code,
-          mockPrice
+          mockPrice,
+          mockCartCurrency
         )
       ).rejects.toBeInstanceOf(PromotionCodeCouldNotBeAttachedError);
     });
 
     it('throws an error if promotion code is not valid', async () => {
       const mockPromotionCode = StripePromotionCodeFactory();
       const mockPrice = StripePriceFactory();
+      const mockCartCurrency = mockPrice.currency;
 
       jest
         .spyOn(promotionCodeManager, 'retrieveByName')
@@ -207,10 +220,35 @@ describe('PromotionCodeManager', () => {
       await expect(
         promotionCodeManager.assertValidPromotionCodeNameForPrice(
           mockPromotionCode.code,
-          mockPrice
+          mockPrice,
+          mockCartCurrency
         )
       ).rejects.toBeInstanceOf(PromotionCodeCouldNotBeAttachedError);
     });
+
+    it('throws an error if currencies do no match', async () => {
+      const mockPrice = StripePriceFactory({
+        currency: 'cad',
+      });
+      const mockPromotionCode = StripePromotionCodeFactory({
+        coupon: StripeCouponFactory({
+          currency: 'cad',
+        }),
+      });
+      const mockCartCurrency = 'usd';
+
+      jest
+        .spyOn(promotionCodeManager, 'retrieveByName')
+        .mockResolvedValue(mockPromotionCode);
+
+      await expect(
+        promotionCodeManager.assertValidPromotionCodeNameForPrice(
+          mockPromotionCode.code,
+          mockPrice,
+          mockCartCurrency
+        )
+      ).rejects.toBeInstanceOf(CouponErrorInvalid);
+    });
   });
 
   describe('applyPromoCodeToSubscription', () => {

libs/payments/customer/src/lib/promotionCode.manager.ts

@@ -9,7 +9,10 @@ import {
   StripePrice,
   StripePromotionCode,
 } from '@fxa/payments/stripe';
-import { PromotionCodeCouldNotBeAttachedError } from './error';
+import {
+  CouponErrorInvalid,
+  PromotionCodeCouldNotBeAttachedError,
+} from './error';
 import { assertPromotionCodeApplicableToPrice } from './util/assertPromotionCodeApplicableToPrice';
 import { assertPromotionCodeActive } from './util/assertPromotionCodeActive';
 import { getPriceFromSubscription } from './util/getPriceFromSubscription';
@@ -33,12 +36,16 @@ export class PromotionCodeManager {
 
   async assertValidPromotionCodeNameForPrice(
     promoCodeName: string,
-    price: StripePrice
+    price: StripePrice,
+    cartCurrency: string
   ) {
     const promoCode = await this.retrieveByName(promoCodeName);
     if (!promoCode)
       throw new PromotionCodeCouldNotBeAttachedError('PromoCode not found');
 
+    if (promoCode.coupon.currency !== cartCurrency)
+      throw new CouponErrorInvalid();
+
     await this.assertValidPromotionCodeForPrice(promoCode, price);
   }
 

libs/payments/ui/src/lib/client/components/SelectTaxLocation/index.tsx

@@ -241,7 +241,10 @@ const Expanded = ({
         </Form.Message>
         {serverErrors.productNotAvailable && (
           <Form.Message>
-            <Localized id="select-tax-location-product-not-available">
+            <Localized
+              id="select-tax-location-product-not-available"
+              vars={{ productName }}
+            >
               <p className="mt-1 text-alert-red" role="alert">
                 {productName} is not available in this location.
               </p>