Skip to content

Commit 8df7582

Browse files
chore(settings): change "Not Set" to "Not set"
Because: * Jeff says Not Set should be Not set This commit: * changes code to match copy
1 parent 3c0e48c commit 8df7582

16 files changed

Lines changed: 25 additions & 25 deletions

File tree

packages/functional-tests/tests/key-stretching-v2/recoveryKeyUpgrade.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ test.describe('severity-2 #smoke', () => {
2626
await confirmSignupCode.fillOutCodeForm(code);
2727

2828
await expect(page).toHaveURL(/settings/);
29-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
29+
await expect(settings.recoveryKey.status).toHaveText('Not set');
3030

3131
await settings.recoveryKey.createButton.click();
3232

packages/functional-tests/tests/misc/recoveryKeyPromoInline.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ test.describe('recovery key promo', () => {
234234
await page.waitForURL(/settings/);
235235

236236
await expect(settings.settingsHeading).toBeVisible();
237-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
237+
await expect(settings.recoveryKey.status).toHaveText('Not set');
238238

239239
await settings.signOut();
240240

packages/functional-tests/tests/misc/recoveryKeyPromoSettingsBanner.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ test.describe('recovery key promo', () => {
2323
await signin.fillOutPasswordForm(credentials.password);
2424

2525
await expect(settings.settingsHeading).toBeVisible();
26-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
26+
await expect(settings.recoveryKey.status).toHaveText('Not set');
2727

2828
await inlineRecoveryKey.getBannerCreateLink().click();
2929

@@ -55,7 +55,7 @@ test.describe('recovery key promo', () => {
5555
await signin.fillOutPasswordForm(credentials.password);
5656

5757
await expect(settings.settingsHeading).toBeVisible();
58-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
58+
await expect(settings.recoveryKey.status).toHaveText('Not set');
5959

6060
await inlineRecoveryKey.getBannerCreateLink().click();
6161

packages/functional-tests/tests/resetPassword/resetPassword2FA.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ test.describe('severity-1 #smoke', () => {
335335
await expect(settings.settingsHeading).toBeVisible();
336336

337337
// Recovery key has been removed
338-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
338+
await expect(settings.recoveryKey.status).toHaveText('Not set');
339339
});
340340

341341
test('provide invalid recovery key then reset with totp authenticator code', async ({

packages/functional-tests/tests/resetPassword/resetPasswordRecoveryKey.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ test.describe('severity-1 #smoke', () => {
155155
'Your password has been reset'
156156
);
157157

158-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
158+
await expect(settings.recoveryKey.status).toHaveText('Not set');
159159

160160
// update password for cleanup function
161161
credentials.password = newPassword;
@@ -239,7 +239,7 @@ test.describe('severity-1 #smoke', () => {
239239
recoveryKey: RecoveryKeyPage,
240240
settings: SettingsPage
241241
): Promise<string> {
242-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
242+
await expect(settings.recoveryKey.status).toHaveText('Not set');
243243

244244
await settings.recoveryKey.createButton.click();
245245

packages/functional-tests/tests/settings/recoveryKey.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ test.describe('severity-1 #smoke', () => {
3030
await settings.goto();
3131

3232
await expect(settings.settingsHeading).toBeVisible();
33-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
33+
await expect(settings.recoveryKey.status).toHaveText('Not set');
3434

3535
await settings.recoveryKey.createButton.click();
3636

@@ -61,7 +61,7 @@ test.describe('severity-1 #smoke', () => {
6161
await settings.goto();
6262

6363
await expect(settings.settingsHeading).toBeVisible();
64-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
64+
await expect(settings.recoveryKey.status).toHaveText('Not set');
6565

6666
await settings.recoveryKey.createButton.click();
6767

@@ -121,7 +121,7 @@ test.describe('severity-1 #smoke', () => {
121121
await settings.goto();
122122

123123
await expect(settings.settingsHeading).toBeVisible();
124-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
124+
await expect(settings.recoveryKey.status).toHaveText('Not set');
125125

126126
await settings.recoveryKey.createButton.click();
127127

@@ -147,7 +147,7 @@ test.describe('severity-1 #smoke', () => {
147147
await expect(settings.alertBar).toHaveText(
148148
'Account recovery key removed'
149149
);
150-
await expect(settings.recoveryKey.status).toHaveText('Not Set');
150+
await expect(settings.recoveryKey.status).toHaveText('Not set');
151151
});
152152
});
153153
});

packages/fxa-settings/src/components/Settings/Security/en.ftl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ security-password =
77
# Variables:
88
# $date (String) - a localized date and time string
99
security-password-created-date = Created { $date }
10-
security-not-set = Not Set
10+
security-not-set = Not set
1111
security-action-create = Create
1212
security-set-password = Set a password to sync and use certain account security features.
1313

packages/fxa-settings/src/components/Settings/Security/index.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe('Security', () => {
3535
expect(await screen.findByText('Account recovery key')).toBeTruthy();
3636
expect(await screen.findByText('Two-step authentication')).toBeTruthy();
3737

38-
expect(await screen.findAllByText('Not Set')).toHaveLength(1);
38+
expect(await screen.findAllByText('Not set')).toHaveLength(1);
3939
expect(await screen.findAllByText('Disabled')).toHaveLength(1);
4040
});
4141

@@ -113,7 +113,7 @@ describe('Security', () => {
113113
const passwordRouteLink = screen.getByTestId('password-unit-row-route');
114114

115115
await screen.findByText('Set a password', { exact: false });
116-
expect(await screen.findAllByText('Not Set')).toHaveLength(2);
116+
expect(await screen.findAllByText('Not set')).toHaveLength(2);
117117
expect(await screen.findAllByText('Disabled')).toHaveLength(1);
118118

119119
expect(passwordRouteLink).toHaveTextContent('Create');

packages/fxa-settings/src/components/Settings/Security/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const PwdDate = ({ passwordCreated }: { passwordCreated: number }) => {
4040
export const Security = forwardRef<HTMLDivElement>((_, ref) => {
4141
const { passwordCreated, hasPassword } = useAccount();
4242
const { l10n } = useLocalization();
43-
const localizedNotSet = l10n.getString('security-not-set', null, 'Not Set');
43+
const localizedNotSet = l10n.getString('security-not-set', null, 'Not set');
4444

4545
return (
4646
<section data-testid="settings-security" {...{ ref }} id="security-section">

packages/fxa-settings/src/components/Settings/UnitRow/index.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,14 +84,14 @@ describe('UnitRow', () => {
8484
renderWithRouter(
8585
<UnitRow
8686
header="Display name"
87-
defaultHeaderValueText="Not Set"
87+
defaultHeaderValueText="Not set"
8888
ctaText="Create"
8989
route="/display_name"
9090
/>
9191
);
9292

9393
expect(screen.getByTestId('unit-row-header-value').textContent).toContain(
94-
'Not Set'
94+
'Not set'
9595
);
9696
expect(screen.getByTestId('unit-row-route').textContent).toContain(
9797
'Create'

0 commit comments

Comments
 (0)