Merge pull request #18897 from mozilla/FXA-11640-cart-error

fix(payments-next): CartError: Cart not created: Out of range value for column 'amount' at row 1

Author: elizabeth-ilina

libs/payments/cart/src/lib/cart.manager.in.spec.ts

@@ -99,6 +99,14 @@ describe('CartManager', () => {
         expect(error.jse_cause).not.toBeUndefined();
       }
     });
+
+    it('succeeds - creates a cart with a negative amount', async () => {
+      const setupCart = SetupCartFactory({
+        amount: -500,
+      });
+      const cart = await cartManager.createCart(setupCart);
+      expect(cart).toEqual(expect.objectContaining(setupCart));
+    });
   });
 
   describe('createErrorCart', () => {
@@ -108,7 +116,7 @@ describe('CartManager', () => {
       });
       const cart = await cartManager.createErrorCart(
         setupCart,
-        CartErrorReasonId.CartEligibilityStatusSame
+        CartErrorReasonId.CART_ELIGIBILITY_STATUS_SAME
       );
       expect(cart).toEqual(expect.objectContaining(setupCart));
     });
@@ -121,7 +129,7 @@ describe('CartManager', () => {
       try {
         await cartManager.createErrorCart(
           setupCart,
-          CartErrorReasonId.CartEligibilityStatusInvalid
+          CartErrorReasonId.CART_ELIGIBILITY_STATUS_INVALID
         );
       } catch (error) {
         expect(error).toBeInstanceOf(CartNotCreatedError);

libs/shared/db/mysql/account/src/test/carts.sql

@@ -13,7 +13,7 @@ CREATE TABLE `carts` (
   `couponCode` varchar(255) COLLATE utf8mb4_bin DEFAULT NULL,
   `stripeCustomerId` varchar(32) COLLATE utf8mb4_bin DEFAULT NULL,
   `email` varchar(255) COLLATE utf8mb4_bin DEFAULT NULL,
-  `amount` int unsigned NOT NULL,
+  `amount` int NOT NULL,
   `version` smallint unsigned DEFAULT 0 NOT NULL,
   `eligibilityStatus` enum('create', 'upgrade', 'downgrade', 'blocked_iap', 'invalid') COLLATE utf8mb4_bin NOT NULL,
   PRIMARY KEY (`id`),

packages/db-migrations/databases/fxa/patches/patch-170-171.sql

@@ -0,0 +1,3 @@
+ALTER TABLE carts MODIFY COLUMN amount INT NOT NULL;
+
+UPDATE dbMetadata SET value = '171' WHERE name = 'schema-patch-level';

packages/db-migrations/databases/fxa/patches/patch-171-170.sql

@@ -0,0 +1,3 @@
+-- ALTER TABLE carts MODIFY COLUMN amount INT UNSIGNED NOT NULL;
+
+-- UPDATE dbMetadata SET value = '170' WHERE name = 'schema-patch-level';

packages/db-migrations/databases/fxa/target-patch.json

@@ -1,3 +1,3 @@
 {
-  "level": 170
+  "level": 171
 }