Skip to content

Commit 8a1b952

Browse files
Merge pull request #20047 from mozilla/FXA-13049
feat(settings): Add passkey to MFA scopes
2 parents 82c82d2 + 8e9429a commit 8a1b952

3 files changed

Lines changed: 13 additions & 5 deletions

File tree

packages/fxa-auth-server/config/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2672,7 +2672,7 @@ const convictConf = convict({
26722672
env: 'MFA__ENABLED',
26732673
},
26742674
actions: {
2675-
default: ['test', '2fa', 'email', 'recovery_key', 'password'],
2675+
default: ['test', '2fa', 'email', 'recovery_key', 'password', 'passkeys'],
26762676
doc: 'Actions protected by MFA',
26772677
format: Array,
26782678
env: 'MFA__ACTIONS',

packages/fxa-settings/src/components/Settings/SubRow/index.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -463,12 +463,11 @@ export const PasskeySubRow = ({
463463
/>
464464
{deleteModalRevealed && (
465465
<MfaGuard
466-
// TODO: replace with actual required scope and reason when available
467-
requiredScope="test"
466+
requiredScope="passkeys"
468467
onDismissCallback={async () => {
469468
hideDeleteModal();
470469
}}
471-
reason={MfaReason.test}
470+
reason={MfaReason.removePasskey}
472471
>
473472
<Modal
474473
onDismiss={hideDeleteModal}

packages/fxa-settings/src/lib/types.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ export enum MfaReason {
3636
createBackupCodes = 'create backup codes',
3737
createRecoveryKey = 'create recovery key',
3838
removeRecoveryKey = 'remove recovery key',
39+
createPasskey = 'create passkey',
40+
renamePasskey = 'rename passkey',
41+
removePasskey = 'remove passkey',
3942
test = 'test',
4043
}
4144

@@ -92,4 +95,10 @@ export type TotpInfo = {
9295
secret: string;
9396
};
9497

95-
export type MfaScope = 'test' | '2fa' | 'email' | 'recovery_key' | 'password';
98+
export type MfaScope =
99+
| 'test'
100+
| '2fa'
101+
| 'email'
102+
| 'recovery_key'
103+
| 'password'
104+
| 'passkeys';

0 commit comments

Comments
 (0)