Skip to content

Commit 8996424

Browse files
authored
Merge pull request #18229 from mozilla/FXA-10250
feat(sms): Create 'adding' and 'using' backup phone feature flags
2 parents a4e71cf + 82c0335 commit 8996424

4 files changed

Lines changed: 25 additions & 1 deletion

File tree

packages/fxa-content-server/server/config/local.json-dist

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@
6767
},
6868
"featureFlags": {
6969
"sendFxAStatusOnSettings": true,
70-
"recoveryCodeSetupOnSyncSignIn": true
70+
"recoveryCodeSetupOnSyncSignIn": true,
71+
"enableAdding2FABackupPhone": true,
72+
"enableUsing2FABackupPhone": true
7173
}
7274
}

packages/fxa-content-server/server/lib/beta-settings.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,12 @@ const settingsConfig = {
105105
recoveryCodeSetupOnSyncSignIn: config.get(
106106
'featureFlags.recoveryCodeSetupOnSyncSignIn'
107107
),
108+
enableAdding2FABackupPhone: config.get(
109+
'featureFlags.enableAdding2FABackupPhone'
110+
),
111+
enableUsing2FABackupPhone: config.get(
112+
'featureFlags.enableUsing2FABackupPhone'
113+
),
108114
},
109115
};
110116

packages/fxa-content-server/server/lib/configuration.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,18 @@ const conf = (module.exports = convict({
232232
format: Boolean,
233233
env: 'FEATURE_FLAGS_RECOVERY_CODE_SETUP_ON_SYNC_SIGN_IN',
234234
},
235+
enableAdding2FABackupPhone: {
236+
default: false,
237+
doc: 'Enables adding a new backup phone number for 2FA',
238+
format: Boolean,
239+
env: 'FEATURE_FLAGS_ADDING_2FA_BACKUP_PHONE',
240+
},
241+
enableUsing2FABackupPhone: {
242+
default: false,
243+
doc: 'Enables using and managing an already confirmed backup phone number for 2FA',
244+
format: Boolean,
245+
env: 'FEATURE_FLAGS_USING_2FA_BACKUP_PHONE',
246+
},
235247
},
236248
showReactApp: {
237249
emailFirstRoutes: {

packages/fxa-settings/src/lib/config.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ export interface Config {
8989
featureFlags?: {
9090
keyStretchV2?: boolean;
9191
recoveryCodeSetupOnSyncSignIn?: boolean;
92+
enableAdding2FABackupPhone?: boolean;
93+
enableUsing2FABackupPhone?: boolean;
9294
};
9395
}
9496

@@ -166,6 +168,8 @@ export function getDefault() {
166168
},
167169
featureFlags: {
168170
recoveryCodeSetupOnSyncSignIn: false,
171+
enableAdding2FABackupPhone: false,
172+
enableUsing2FABackupPhone: false,
169173
},
170174
} as Config;
171175
}

0 commit comments

Comments
 (0)