polish(shared): Remove more filtering logic

Author: dschom

libs/shared/sentry-nest/src/lib/reporting.ts

@@ -3,7 +3,6 @@ import { ExecutionContext, HttpException } from '@nestjs/common';
 import { GqlContextType, GqlExecutionContext } from '@nestjs/graphql';
 import { ApolloServerErrorCode } from '@apollo/server/errors';
 
-import { CommonPiiActions, SqsMessageFilter } from '@fxa/shared/sentry-utils';
 import { GraphQLError } from 'graphql';
 import { Message } from '@aws-sdk/client-sqs';
 import { Request } from 'express';
@@ -13,11 +12,6 @@ export interface ExtraContext {
   fieldData: Record<string, string>;
 }
 
-const sqsMessageFilter = new SqsMessageFilter([
-  CommonPiiActions.emailValues,
-  CommonPiiActions.tokenValues,
-]);
-
 /**
  * Capture a SQS Error to Sentry with additional context.
  *
@@ -27,7 +21,6 @@ const sqsMessageFilter = new SqsMessageFilter([
 export function captureSqsError(err: Error, message?: Message): void {
   Sentry.withScope((scope) => {
     if (message?.Body) {
-      message = sqsMessageFilter.filter(message);
       scope.setContext('SQS Message', message as Record<string, unknown>);
     }
     Sentry.captureException(err);

packages/fxa-auth-server/lib/sentry.js

@@ -13,10 +13,6 @@ const {
   formatMetadataValidationErrorMessage,
   reportValidationError,
 } = require('fxa-shared/sentry/report-validation-error');
-// Matches uid, session, oauth and other common tokens which we would
-// prefer not to include in Sentry reports.
-const TOKENREGEX = /[a-fA-F0-9]{32,}/gi;
-const FILTERED = '[Filtered]';
 
 function reportSentryMessage(message, captureContext) {
   Sentry.withScope((scope) => {
@@ -100,9 +96,7 @@ function reportSentryError(err, request) {
       const attempt = cause.attempt;
       if (attempt) {
         causeContext.method = attempt.method;
-        causeContext.path = attempt.path
-          ? attempt.path.replace(TOKENREGEX, FILTERED)
-          : null;
+        causeContext.path = attempt.path;
       }
       scope.setContext('cause', causeContext);
     }

packages/fxa-shared/nestjs/sentry/reporting.spec.ts

@@ -1,16 +1,9 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-import * as uuid from 'uuid';
 
 import { isAuthServerError } from './reporting';
 
-const FILTERED = '[Filtered]';
-
-function getUid() {
-  return uuid.v4().replace(/-/g, '');
-}
-
 describe('detects auth server error', () => {
   it('flags when code and errno are present', () => {
     const result = isAuthServerError({

packages/fxa-shared/nestjs/sentry/reporting.ts

@@ -6,18 +6,9 @@ import { ApolloServerErrorCode } from '@apollo/server/errors';
 import { GraphQLError } from 'graphql';
 import { GqlContextType, GqlExecutionContext } from '@nestjs/graphql';
 import * as Sentry from '@sentry/node';
-import { ErrorEvent } from '@sentry/core';
 import { Message } from '@aws-sdk/client-sqs';
 import { Request } from 'express';
 
-import { CommonPiiActions } from '../../sentry/pii-filter-actions';
-import { SqsMessageFilter } from '../../sentry/pii-filters';
-
-const sqsMessageFilter = new SqsMessageFilter([
-  CommonPiiActions.emailValues,
-  CommonPiiActions.tokenValues,
-]);
-
 export interface ExtraContext {
   name: string;
   fieldData: Record<string, string>;
@@ -74,7 +65,6 @@ export function isOriginallyHttpError(
 export function captureSqsError(err: Error, message?: Message): void {
   Sentry.withScope((scope) => {
     if (message?.Body) {
-      message = sqsMessageFilter.filter(message);
       scope.setContext('SQS Message', message as Record<string, unknown>);
     }
     Sentry.captureException(err);