Merge pull request #18856 from mozilla/FXA-2704

fix(settings): make ModalVerifySession's input validation work on the first attempt

Author: MagentaManifold

packages/fxa-settings/src/components/Settings/ModalVerifySession/index.tsx

@@ -74,8 +74,11 @@ export const ModalVerifySession = ({
     getStatus();
   }, [session, onCompleted]);
 
-  const buttonDisabled =
-    !formState.isDirty || !formState.isValid || account.loading;
+  // Destructure formState in advance to avoid logical operator short-circuiting
+  // causing the isValid field to be conditionally subscribed.
+  const { isDirty, isValid } = formState;
+  const buttonDisabled = !isDirty || !isValid || account.loading;
+
   return (
     !session.verified && (
       <Modal