Merge pull request #20345 from mozilla/PAY-3590-fix-and-remove-comments

fix(payments-next): Fix and remove comments

Author: elizabeth-ilina

libs/payments/ui/src/lib/client/components/ChurnCancel/index.tsx

@@ -180,10 +180,7 @@ export function ChurnCancel({
           action: 'redeem_coupon',
           outcome: 'redeem_success',
         });
-        // TODO: This is a workaround to match existing legacy behavior.
-        // Fix as part of redesign
         setShowSuccess(true);
-        await new Promise((resolve) => setTimeout(resolve, 500));
       } else {
         glean.recordRetentionFlowResult({
           ...retentionFlowBase,
@@ -234,10 +231,7 @@ export function ChurnCancel({
           action: 'cancel_subscription',
           outcome: 'customer_canceled',
         });
-        // TODO: This is a workaround to match existing legacy behavior.
-        // Fix as part of redesign
         setShowCancelSuccess(true);
-        await new Promise((resolve) => setTimeout(resolve, 500)); // optional: match legacy feel
       } else {
         glean.recordRetentionFlowResult({
           ...retentionFlowBase,

libs/payments/ui/src/lib/client/components/ChurnStaySubscribed/index.tsx

@@ -171,10 +171,7 @@ export function ChurnStaySubscribed({
           action: 'redeem_coupon',
           outcome: 'redeem_success',
         });
-        // TODO: This is a workaround to match existing legacy behavior.
-        // Fix as part of redesign
         setShowSuccess(true);
-        await new Promise((resolve) => setTimeout(resolve, 500));
       } else {
         glean.recordRetentionFlowResult({
           ...retentionFlowBase,
@@ -223,10 +220,7 @@ export function ChurnStaySubscribed({
           action: 'stay_subscribed',
           outcome: 'stay_subscribed_success',
         });
-        // TODO: This is a workaround to match existing legacy behavior.
-        // Fix as part of redesign
         setShowSuccess(true);
-        await new Promise((resolve) => setTimeout(resolve, 500));
       } else {
         glean.recordRetentionFlowResult({
           ...retentionFlowBase,

libs/payments/ui/src/lib/client/components/InterstitialOffer/index.tsx

@@ -164,10 +164,7 @@ export function InterstitialOffer({
           action: 'cancel_subscription',
           outcome: 'customer_canceled',
         });
-        // TODO: This is a workaround to match existing legacy behavior.
-        // Fix as part of redesign
         setShowCancelSuccess(true);
-        await new Promise((resolve) => setTimeout(resolve, 500));
       } else {
         glean.recordInterstitialOfferResult({
           ...interstitialOfferBase,

libs/payments/ui/src/lib/client/components/StaySubscribed/index.tsx

@@ -68,11 +68,7 @@ export function StaySubscribed({
     setResubscribeActionError(false);
 
     const result = await resubscribeSubscriptionAction(userId, subscriptionId);
-    if (result.ok) {
-      // TODO: This is a workaround to match existing legacy behavior.
-      // Fix as part of redesign
-      await new Promise((resolve) => setTimeout(resolve, 500));
-    } else {
+    if (!result.ok) {
       setResubscribeActionError(true);
     }
     setLoading(false);