Skip to content

Commit 6128866

Browse files
authored
Merge pull request #18318 from mozilla/fix-l10n-string-mismatches
fix(l10n): Fix mismatched or missing l10n
2 parents 3d2d3de + 9185602 commit 6128866

7 files changed

Lines changed: 15 additions & 7 deletions

File tree

packages/functional-tests/tests/settings/recoveryPhone.spec.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,7 @@ test.describe('severity-1 #smoke', () => {
148148
});
149149

150150
await page.waitForURL(/settings/);
151+
await expect(settings.settingsHeading).toBeVisible();
151152

152153
// Remove totp so account can be deleted
153154
await settings.disconnectTotp();

packages/fxa-settings/src/components/Settings/Page2faReplaceRecoveryCodes/en.ftl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,5 @@ tfa-replace-code-success-1 = New codes have been created. Save these one-time us
88
tfa-replace-code-success-alert-4 = Backup authentication codes updated
99
tfa-replace-code-1-2 = Step 1 of 2
1010
tfa-replace-code-2-2 = Step 2 of 2
11+
12+
tfa-enter-code-to-confirm-v2 = Please enter one of your new backup authentication codes to confirm that you have saved them. Your old backup authentication codes will be disabled once this step is completed.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
## PageSetupRecoveryPhone
22

33
page-setup-recovery-phone-heading = Add recovery phone
4+
5+
page-setup-recovery-phone-back-button-title = Back to settings

packages/fxa-settings/src/components/Settings/PageRecoveryPhoneSetup/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const PageRecoveryPhoneSetup = (_: RouteComponentProps) => {
2828
navigate(SETTINGS_PATH + '#two-step-authentication', { replace: true });
2929

3030
const localizedPageTitle = ftlMsgResolver.getMsg(
31-
'page-setup-recovery-phone-title',
31+
'page-setup-recovery-phone-heading',
3232
'Add recovery phone'
3333
);
3434

packages/fxa-settings/src/components/Settings/PageTwoStepAuthentication/en.ftl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ tfa-input-enter-totp-v2 =
3737
tfa-save-these-codes-1 = Save these one-time use backup authentication codes in a safe place for when
3838
you don’t have your mobile device.
3939
40-
tfa-enter-code-to-confirm-v2 = Please enter one of your new backup authentication codes to
41-
confirm that you have saved them. Your old backup authentication codes will be disabled once this step is completed.
40+
# codes here refers to backup authentication codes
41+
tfa-enter-code-to-confirm-setup = Confirm you saved your codes by entering one. Without these codes, you might not be able to sign in if you don’t have your authenticator app.
42+
4243
tfa-enter-recovery-code-1 =
4344
.label = Enter a backup authentication code
4445

packages/fxa-settings/src/components/Settings/PageTwoStepAuthentication/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -407,11 +407,11 @@ export const PageTwoStepAuthentication = (_: RouteComponentProps) => {
407407
)}
408408
{totpVerified && recoveryCodesAcknowledged && (
409409
<form onSubmit={recoveryCodeForm.handleSubmit(onRecoveryCodeSubmit)}>
410-
<Localized id="tfa-enter-code-to-confirm-1">
410+
<Localized id="tfa-enter-code-to-confirm-setup">
411411
<p className="mt-4 mb-4">
412-
Please enter one of your backup authentication codes now to
413-
confirm you've saved it. You’ll need a code to login if you don’t
414-
have access to your mobile device.
412+
Confirm you saved your codes by entering one. Without these codes,
413+
you might not be able to sign in if you don’t have your
414+
authenticator app.
415415
</p>
416416
</Localized>
417417
<div className="mt-4 mb-6" data-testid="recovery-code-input">

packages/fxa-settings/src/pages/Signin/SigninRecoveryCode/en.ftl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ signin-recovery-code-heading = Sign in
77
signin-recovery-code-sub-heading = Enter backup authentication code
88
# codes here refers to backup authentication codes
99
signin-recovery-code-instruction-v3 = Enter one of the one-time-use codes you saved when you set up two-step authentication.
10+
# code here refers to backup authentication code
11+
signin-recovery-code-input-label-v2 = Enter 10-character code
1012
# Form button to confirm if the backup authentication code entered by the user is valid
1113
signin-recovery-code-confirm-button = Confirm
1214
# Link to go to the page to use recovery phone instead

0 commit comments

Comments
 (0)