Merge pull request #20226 from mozilla/FXA-13303

task(passkeys): Use AppErrors instead of passkey.errors.ts

Author: dschom

libs/accounts/errors/src/app-error.ts

@@ -1741,13 +1741,18 @@ export class AppError extends Error {
     });
   }
 
-  static passkeyLimitReached() {
-    return new AppError({
-      code: 400,
-      error: 'Bad Request',
-      errno: ERRNO.PASSKEY_LIMIT_REACHED,
-      message: 'Maximum number of passkeys reached',
-    });
+  static passkeyLimitReached(limit: number) {
+    return new AppError(
+      {
+        code: 400,
+        error: 'Bad Request',
+        errno: ERRNO.PASSKEY_LIMIT_REACHED,
+        message: 'Maximum number of passkeys reached',
+      },
+      {
+        limit,
+      }
+    );
   }
 
   static passkeyAuthenticationFailed() {
@@ -1777,6 +1782,15 @@ export class AppError extends Error {
     });
   }
 
+  static passkeyChallengeNotFound() {
+    return new AppError({
+      code: 404,
+      error: 'Not Found',
+      errno: ERRNO.PASSKEY_CHALLENGE_NOT_FOUND,
+      message: 'Passkey challenge not found',
+    });
+  }
+
   private static decorateErrorWithRequest(error: AppError, request?: Request) {
     if (request) {
       error.output.payload.request = {

libs/accounts/errors/src/index.spec.ts

@@ -369,7 +369,7 @@ describe('AppErrors', () => {
     });
 
     it('creates passkeyLimitReached', () => {
-      const result = AppError.passkeyLimitReached();
+      const result = AppError.passkeyLimitReached(3);
       expect(result).toBeInstanceOf(AppError);
       expect(result).toMatchObject({
         errno: 226,
@@ -379,6 +379,7 @@ describe('AppErrors', () => {
           payload: {
             error: 'Bad Request',
             errno: 226,
+            limit: 3,
           },
         },
       });

libs/accounts/passkey/src/index.ts

@@ -10,7 +10,6 @@
  * - PasskeyService: High-level business logic for passkey operations
  * - PasskeyManager: Database access layer for passkey storage
  * - Repository functions: Pure data access functions (findPasskeysByUid, etc.)
- * - PasskeyError: Base error class for passkey-specific errors
  * - PasskeyConfig: Configuration class
  *
  * Types (import directly from shared):
@@ -23,7 +22,6 @@
 export * from './lib/passkey.service';
 export * from './lib/passkey.manager';
 export * from './lib/passkey.repository';
-export * from './lib/passkey.errors';
 export * from './lib/passkey.config';
 export * from './lib/passkey.provider';
 export * from './lib/passkey.challenge.manager';