Skip to content

Commit 490bfe5

Browse files
authored
Merge pull request #20421 from mozilla/pay-3321-stripe-webhook-fix
fix(payments-api): stripe webhooks not recording glean
2 parents 724c270 + f76af7e commit 490bfe5

2 files changed

Lines changed: 13 additions & 6 deletions

File tree

apps/payments/api/project.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555
"continuous": true,
5656
"executor": "@nx/js:node",
5757
"defaultConfiguration": "development",
58-
"dependsOn": ["build"],
5958
"options": {
6059
"buildTarget": "payments-api:build",
6160
"runBuildTargetDependencies": false
@@ -70,7 +69,8 @@
7069
}
7170
},
7271
"start": {
73-
"command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__"
72+
"command": "pm2 start apps/payments/api/pm2.config.js && yarn check:url localhost:3037/__heartbeat__",
73+
"dependsOn": []
7474
},
7575
"stop": {
7676
"command": "pm2 stop apps/payments/api/pm2.config.js"

apps/payments/api/src/app/app.module.ts

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,12 @@ import { CurrencyManager } from '@fxa/payments/currency';
3434
import { AccountDatabaseNestFactory } from '@fxa/shared/db/mysql/account';
3535
import { AccountManager } from '@fxa/shared/account/account';
3636
import { CartManager } from '@fxa/payments/cart';
37-
import { CmsContentValidationManager, ProductConfigurationManager, StrapiClient } from '@fxa/shared/cms';
3837
import {
39-
MockPaymentsGleanFactory,
38+
CmsContentValidationManager,
39+
ProductConfigurationManager,
40+
StrapiClient,
41+
} from '@fxa/shared/cms';
42+
import {
4043
PaymentsGleanManager,
4144
PaymentsGleanService,
4245
} from '@fxa/payments/metrics';
@@ -60,7 +63,12 @@ import { NimbusClient, NimbusClientConfig } from '@fxa/shared/experiments';
6063
}),
6164
}),
6265
],
63-
controllers: [AppController, CmsWebhooksController, FxaWebhooksController, StripeWebhooksController],
66+
controllers: [
67+
AppController,
68+
CmsWebhooksController,
69+
FxaWebhooksController,
70+
StripeWebhooksController,
71+
],
6472
providers: [
6573
Logger,
6674
AccountDatabaseNestFactory,
@@ -96,7 +104,6 @@ import { NimbusClient, NimbusClientConfig } from '@fxa/shared/experiments';
96104
NimbusManagerConfig,
97105
NimbusClient,
98106
NimbusClientConfig,
99-
MockPaymentsGleanFactory,
100107
],
101108
})
102109
export class AppModule {}

0 commit comments

Comments
 (0)