Skip to content

Commit 2e533ec

Browse files
authored
Merge pull request #18256 from mozilla/FXA-10806
chore(test): remove chromium functional tests
2 parents 33cba75 + 469e5a0 commit 2e533ec

5 files changed

Lines changed: 2 additions & 73 deletions

File tree

.circleci/config.yml

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -342,32 +342,6 @@ commands:
342342
RELIER_DOMAIN: << pipeline.parameters.relier-domain >>
343343
UNTRUSTED_RELIER_DOMAIN: << pipeline.parameters.untrusted-relier-domain >>
344344

345-
run-playwright-tests-chromium:
346-
parameters:
347-
project:
348-
type: string
349-
steps:
350-
- run:
351-
name: Running Playwright tests
352-
# Supports 'Re-run failed tests only'. See this for more info: https://circleci.com/docs/rerun-failed-tests-only/
353-
command: |
354-
npx nx build fxa-auth-client
355-
cd packages/functional-tests/tests
356-
TEST_FILES=$(circleci tests glob "./**/*.spec.ts")
357-
cd ..
358-
echo $TEST_FILES | circleci tests run \
359-
--command="xargs yarn playwright test --project=<< parameters.project >> $GREP" \
360-
--verbose \
361-
--split-by=timings \
362-
--timings-type=classname
363-
environment:
364-
NODE_OPTIONS: --dns-result-order=ipv4first
365-
ACCOUNTS_DOMAIN: << pipeline.parameters.accounts-domain >>
366-
PAYMENTS_DOMAIN: << pipeline.parameters.payments-domain >>
367-
ACCOUNTS_API_DOMAIN: << pipeline.parameters.accounts-api-domain >>
368-
RELIER_DOMAIN: << pipeline.parameters.relier-domain >>
369-
UNTRUSTED_RELIER_DOMAIN: << pipeline.parameters.untrusted-relier-domain >>
370-
371345
store-artifacts:
372346
steps:
373347
- run:
@@ -730,31 +704,6 @@ jobs:
730704
project: local
731705
- store-artifacts
732706

733-
playwright-functional-tests-chromium:
734-
parameters:
735-
parallelism:
736-
type: integer
737-
default: 8 # this should correspond with the resource-class defined in the executor
738-
executor: functional-test-executor
739-
parallelism: << parameters.parallelism >>
740-
steps:
741-
- git-checkout
742-
- restore-workspace
743-
- run:
744-
name: Add localhost
745-
command: |
746-
sudo tee -a /etc/hosts \<<<'127.0.0.1 localhost'
747-
sudo cat /etc/hosts
748-
- wait-for-infrastructure
749-
- run:
750-
name: Start services for playwright tests
751-
command: ./packages/functional-tests/scripts/start-services.sh
752-
environment:
753-
NODE_ENV: test
754-
- run-playwright-tests-chromium:
755-
project: local
756-
- store-artifacts
757-
758707
build-and-deploy-storybooks:
759708
executor: default-executor
760709
resource_class: xlarge

packages/functional-tests/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"compile": "tsc --noEmit",
88
"test": "NODE_OPTIONS='--dns-result-order=ipv4first' playwright test --project=local",
99
"test-local": "NODE_OPTIONS='--dns-result-order=ipv4first' playwright test --project=local",
10-
"test-local-chromium": "NODE_OPTIONS='--dns-result-order=ipv4first' playwright test --project=local-chromium",
1110
"test-stage": "NODE_OPTIONS='--dns-result-order=ipv4first' playwright test --project=stage",
1211
"test-production": "NODE_OPTIONS='--dns-result-order=ipv4first' playwright test --project=production",
1312
"format": "prettier --write --config ../../_dev/.prettierrc '**'",

packages/functional-tests/playwright.config.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -79,21 +79,6 @@ export default defineConfig<PlaywrightTestConfig<TestOptions, WorkerOptions>>({
7979
},
8080
} as Project)
8181
),
82-
...TargetNames.map(
83-
(name) =>
84-
({
85-
name: `${name}-chromium`,
86-
use: {
87-
browserName: 'chromium',
88-
targetName: name,
89-
launchOptions: {
90-
headless: !DEBUG,
91-
slowMo: SLOWMO,
92-
},
93-
trace: 'retain-on-failure',
94-
},
95-
} as Project)
96-
),
9782
],
9883
reporter: CI
9984
? [

packages/functional-tests/tests/misc/recoveryKeyPromoInline.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ test.describe('recovery key promo', () => {
1313
config.featureFlags.recoveryCodeSetupOnSyncSignIn !== true,
1414
'inline recovery key setup is not enabled'
1515
);
16-
test.skip(
17-
project.name === 'local-chromium',
18-
'Sync tests can not run on Chrome'
19-
);
2016
});
2117

2218
test('not shown after signup', async ({

packages/functional-tests/tests/subscription-tests/support.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ test.describe('severity-2 #smoke', () => {
5151
credentials,
5252
}, { project }) => {
5353
test.skip(
54-
project.name === 'production' || project.name === 'local-chromium',
55-
'no real payment method available in prod or local-chromium'
54+
project.name === 'production',
55+
'no real payment method available in prod'
5656
);
5757
await relier.goto();
5858
await relier.clickSubscribe();

0 commit comments

Comments
 (0)