Skip to content

Commit 116ddd0

Browse files
committed
fix(inactives): Don't hard navigate when redirectTo is 'settings'
Because: * This is causing the integration to get recreated in Settings, and we're not currently passing params into Settings, meaning the integration query param data is undefined and the active banner is not shown This commit: * Checks that the 'redirectTo' condition in our signin utils does not equal '/settings', to avoid the hard navigate
1 parent 16deb2e commit 116ddd0

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

  • packages/fxa-settings/src/pages/Signin

packages/fxa-settings/src/pages/Signin/utils.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,9 @@ const getNonOAuthNavigationTarget = async (
249249
),
250250
};
251251
}
252-
if (redirectTo) {
252+
// We don't want a hard navigate to `/settings` as it
253+
// clears out the initially created integration.
254+
if (redirectTo && redirectTo !== '/settings') {
253255
return { to: redirectTo, shouldHardNavigate: true };
254256
}
255257
return { to: '/settings' };

0 commit comments

Comments
 (0)