Merge pull request #20188 from mozilla/lodash-pick-native

chore(): replace lodash.pick with native code

Author: toufali

packages/fxa-shared/metrics/amplitude.ts

@@ -3,7 +3,6 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 import Ajv from 'ajv';
-import pick from 'lodash.pick';
 import {
   ParsedUserAgentProperties,
   ParsedUa,
@@ -184,7 +183,11 @@ function mapSubscriptionEventProperties(
       'subscription_id',
       'voluntary_cancellation',
     ];
-    return pick(data, keys);
+    const result: EventData = {};
+    for (const k of keys) {
+      if (k in data) result[k] = data[k];
+    }
+    return result;
   }
 
   return;

packages/fxa-shared/package.json

@@ -294,7 +294,6 @@
     "knex": "^3.1.0",
     "lodash.clonedeep": "^4.5.0",
     "lodash.omitby": "^4.6.0",
-    "lodash.pick": "^4.4.0",
     "moment": "^2.30.1",
     "mozlog": "^3.0.2",
     "mysql": "^2.18.1",

packages/fxa-shared/subscriptions/stripe.ts

@@ -1,5 +1,4 @@
 import Stripe from 'stripe';
-import pick from 'lodash.pick';
 import omitBy from 'lodash.omitby';
 import {
   Plan,
@@ -12,6 +11,15 @@ import { productUpgradeFromProductConfig } from './configuration/utils';
 const isCapabilityKey = (value: string, key: string) =>
   key.startsWith('capabilities');
 
+const pick = (obj: any, ...keys: string[]): any => {
+  if (obj == null) return {};
+  const result: any = {};
+  for (const k of keys) {
+    if (k in obj) result[k] = obj[k];
+  }
+  return result;
+};
+
 export type DeepPartial<T> = {
   [P in keyof T]?: DeepPartial<T[P]>;
 };
@@ -67,7 +75,7 @@ export function filterCustomer(
     'default_payment_method'
   ) as any;
   if (customer.sources?.data) {
-    customer.sources.data = customer.sources.data.map((s) =>
+    customer.sources.data = customer.sources.data.map((s: any) =>
       pick(s, 'id', 'object', 'brand', 'exp_month', 'exp_year', 'last4')
     ) as any;
     customer.sources = pick(customer.sources, 'data') as any;

yarn.lock

@@ -36792,7 +36792,6 @@ __metadata:
     knex: "npm:^3.1.0"
     lodash.clonedeep: "npm:^4.5.0"
     lodash.omitby: "npm:^4.6.0"
-    lodash.pick: "npm:^4.4.0"
     mocha: "npm:^10.4.0"
     moment: "npm:^2.30.1"
     mozlog: "npm:^3.0.2"
@@ -44101,13 +44100,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"lodash.pick@npm:^4.4.0":
-  version: 4.4.0
-  resolution: "lodash.pick@npm:4.4.0"
-  checksum: 10c0/a04c460b95d1aaa44e9513d1dacf72ea74d838da843e45831de9de64c303f13cdde1859702a6f4dcef417816898ffd47c6ae0614c957ac70245bed2809b8d2e2
-  languageName: node
-  linkType: hard
-
 "lodash.snakecase@npm:^4.1.1":
   version: 4.1.1
   resolution: "lodash.snakecase@npm:4.1.1"