Skip to content

Commit 0234c13

Browse files
committed
chore(auth): remove dead code related to /certificate/sign
1 parent 4b3080b commit 0234c13

3 files changed

Lines changed: 1 addition & 8 deletions

File tree

packages/fxa-auth-server/config/index.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2281,12 +2281,6 @@ const convictConf = convict({
22812281
format: String,
22822282
},
22832283
},
2284-
certificateSignDisableRolloutRate: {
2285-
default: 0,
2286-
doc: 'Rollout rate for disabling certificate signing, in the range 0 .. 1',
2287-
env: 'CERTIFICATE_SIGN_DISABLE_ROLLOUT_RATE',
2288-
format: Number,
2289-
},
22902284
cms: {
22912285
enabled: {
22922286
default: false,

packages/fxa-auth-server/lib/metrics/events.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ const IGNORE_ROUTE_FLOW_EVENTS_FOR_PATHS = new Set([
5959
'/account/devices',
6060
'/account/profile',
6161
'/account/sessions',
62-
'/certificate/sign',
6362
'/password/forgot/status',
6463
'/recovery_email/status',
6564
'/jwks',

packages/fxa-auth-server/lib/routes/oauth/token.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -904,7 +904,7 @@ module.exports = ({ log, oauthDB, db, mailer, devices, statsd, glean }) => {
904904
) {
905905
// For desktop, the 'service' parameter for this event gets
906906
// special-cased to 'sync' so that it matches its pre-oauth
907-
// `/certificate/sign` event.
907+
// `/certificate/sign` event. (Note: `/certificate/sign` is now removed.)
908908
// ref: https://github.com/mozilla/fxa/pull/6581#issuecomment-702248031
909909
// Otherwise, for mobile browsers, just use the existing client ID
910910
// to service name mapping used in the metrics code (see the

0 commit comments

Comments
 (0)