refactor: redesign logging system for CLI-friendly output (#561)

* refactor: redesign logging system for CLI-friendly output
* refactor: remove ANSI color support from logger
* fix: address PR review feedback

Author: moonD4rk

CLAUDE.md

@@ -46,7 +46,7 @@ go mod verify
 
 - **Platform code**: use build tags (`_darwin.go`, `_windows.go`, `_linux.go`)
 - **Error handling**: `fmt.Errorf("context: %w", err)` for wrapping, never `_ =` to ignore errors
-- **Logging**: `log.Debugf` for record-level issues, `log.Warnf` for user-visible warnings. Extract methods should return errors, not log them.
+- **Logging**: `log.Debugf` for record-level diagnostics, `log.Infof` for user-facing progress/status, `log.Warnf` for unexpected conditions. Extract methods should return errors, not log them.
 - **Naming**: follow Go conventions — `Config` not `BrowserConfig`, `Extract` not `BrowsingData`
 - **Tests**: use `t.TempDir()` for filesystem tests, `go-sqlmock` for database tests
 - **Architecture**: see `rfcs/` for design documents

browser/chromium/chromium.go

@@ -187,7 +187,6 @@ func (b *Browser) extractCategory(data *types.BrowserData, cat types.Category, m
 func discoverProfiles(userDataDir string, sources map[types.Category][]sourcePath) []string {
 	entries, err := os.ReadDir(userDataDir)
 	if err != nil {
-		log.Debugf("read user data dir %s: %v", userDataDir, err)
 		return nil
 	}
 

browser/chromium/extract_cookie.go

@@ -16,6 +16,8 @@ const defaultCookieQuery = `SELECT name, encrypted_value, host_key, path,
 	has_expires, is_persistent FROM cookies`
 
 func extractCookies(masterKey []byte, path string) ([]types.CookieEntry, error) {
+	var decryptFails int
+	var lastErr error
 	cookies, err := sqliteutil.QueryRows(path, false, defaultCookieQuery,
 		func(rows *sql.Rows) (types.CookieEntry, error) {
 			var (
@@ -33,7 +35,8 @@ func extractCookies(masterKey []byte, path string) ([]types.CookieEntry, error)
 
 			value, err := decryptValue(masterKey, encryptedValue)
 			if err != nil {
-				log.Debugf("decrypt cookie %s on %s: %v", name, host, err)
+				decryptFails++
+				lastErr = err
 			}
 			value = stripCookieHash(value, host)
 			return types.CookieEntry{
@@ -52,6 +55,9 @@ func extractCookies(masterKey []byte, path string) ([]types.CookieEntry, error)
 	if err != nil {
 		return nil, err
 	}
+	if decryptFails > 0 {
+		log.Debugf("decrypt cookies: %d failed: %v", decryptFails, lastErr)
+	}
 
 	sort.Slice(cookies, func(i, j int) bool {
 		return cookies[i].CreatedAt.After(cookies[j].CreatedAt)

browser/chromium/extract_creditcard.go

@@ -12,7 +12,9 @@ const defaultCreditCardQuery = `SELECT COALESCE(guid, ''), name_on_card, expirat
 	card_number_encrypted, COALESCE(nickname, ''), COALESCE(billing_address_id, '') FROM credit_cards`
 
 func extractCreditCards(masterKey []byte, path string) ([]types.CreditCardEntry, error) {
-	return sqliteutil.QueryRows(path, false, defaultCreditCardQuery,
+	var decryptFails int
+	var lastErr error
+	cards, err := sqliteutil.QueryRows(path, false, defaultCreditCardQuery,
 		func(rows *sql.Rows) (types.CreditCardEntry, error) {
 			var guid, name, month, year, nickname, address string
 			var encNumber []byte
@@ -21,7 +23,8 @@ func extractCreditCards(masterKey []byte, path string) ([]types.CreditCardEntry,
 			}
 			number, err := decryptValue(masterKey, encNumber)
 			if err != nil {
-				log.Debugf("decrypt credit card for %s: %v", name, err)
+				decryptFails++
+				lastErr = err
 			}
 			return types.CreditCardEntry{
 				GUID:     guid,
@@ -33,4 +36,11 @@ func extractCreditCards(masterKey []byte, path string) ([]types.CreditCardEntry,
 				Address:  address,
 			}, nil
 		})
+	if err != nil {
+		return nil, err
+	}
+	if decryptFails > 0 {
+		log.Debugf("decrypt credit cards: %d failed: %v", decryptFails, lastErr)
+	}
+	return cards, nil
 }

browser/chromium/extract_password.go

@@ -16,6 +16,8 @@ func extractPasswords(masterKey []byte, path string) ([]types.LoginEntry, error)
 }
 
 func extractPasswordsWithQuery(masterKey []byte, path, query string) ([]types.LoginEntry, error) {
+	var decryptFails int
+	var lastErr error
 	logins, err := sqliteutil.QueryRows(path, false, query,
 		func(rows *sql.Rows) (types.LoginEntry, error) {
 			var url, username string
@@ -26,7 +28,8 @@ func extractPasswordsWithQuery(masterKey []byte, path, query string) ([]types.Lo
 			}
 			password, err := decryptValue(masterKey, pwd)
 			if err != nil {
-				log.Debugf("decrypt password for %s: %v", url, err)
+				decryptFails++
+				lastErr = err
 			}
 			return types.LoginEntry{
 				URL:       url,
@@ -38,6 +41,9 @@ func extractPasswordsWithQuery(masterKey []byte, path, query string) ([]types.Lo
 	if err != nil {
 		return nil, err
 	}
+	if decryptFails > 0 {
+		log.Debugf("decrypt passwords: %d failed: %v", decryptFails, lastErr)
+	}
 
 	sort.Slice(logins, func(i, j int) bool {
 		return logins[i].CreatedAt.After(logins[j].CreatedAt)

browser/firefox/extract_password.go

@@ -37,6 +37,8 @@ func extractPasswords(masterKey []byte, path string) ([]types.LoginEntry, error)
 	}
 
 	var logins []types.LoginEntry
+	var decryptFails int
+	var lastErr error
 	for _, v := range gjson.GetBytes(data, "logins").Array() {
 		url := v.Get("formSubmitURL").String()
 		if url == "" {
@@ -45,11 +47,13 @@ func extractPasswords(masterKey []byte, path string) ([]types.LoginEntry, error)
 
 		user, err := decryptPBE(v.Get("encryptedUsername").String(), masterKey)
 		if err != nil {
-			log.Debugf("decrypt firefox username for %s: %v", url, err)
+			decryptFails++
+			lastErr = err
 		}
 		pwd, err := decryptPBE(v.Get("encryptedPassword").String(), masterKey)
 		if err != nil {
-			log.Debugf("decrypt firefox password for %s: %v", url, err)
+			decryptFails++
+			lastErr = err
 		}
 
 		logins = append(logins, types.LoginEntry{
@@ -59,6 +63,9 @@ func extractPasswords(masterKey []byte, path string) ([]types.LoginEntry, error)
 			CreatedAt: timestamp(v.Get("timeCreated").Int() / 1000),
 		})
 	}
+	if decryptFails > 0 {
+		log.Debugf("decrypt firefox login fields: %d failed: %v", decryptFails, lastErr)
+	}
 
 	sort.Slice(logins, func(i, j int) bool {
 		return logins[i].CreatedAt.After(logins[j].CreatedAt)

browser/firefox/firefox.go

@@ -188,7 +188,6 @@ type resolvedPath struct {
 func discoverProfiles(userDataDir string, sources map[types.Category][]sourcePath) []string {
 	entries, err := os.ReadDir(userDataDir)
 	if err != nil {
-		log.Debugf("read user data dir %s: %v", userDataDir, err)
 		return nil
 	}
 

cmd/hack-browser-data/dump.go

@@ -58,6 +58,7 @@ func dumpCmd() *cobra.Command {
 			}
 
 			for _, b := range browsers {
+				log.Infof("Extracting %s/%s...", b.BrowserName(), b.ProfileName())
 				data, extractErr := b.Extract(categories)
 				if extractErr != nil {
 					log.Errorf("extract %s/%s: %v", b.BrowserName(), b.ProfileName(), extractErr)
@@ -73,7 +74,7 @@ func dumpCmd() *cobra.Command {
 				if err := fileutil.CompressDir(outputDir); err != nil {
 					return fmt.Errorf("compress: %w", err)
 				}
-				log.Warnf("compressed: %s/%s.zip", outputDir, filepath.Base(outputDir))
+				log.Infof("Compressed: %s/%s.zip", outputDir, filepath.Base(outputDir))
 			}
 			return nil
 		},

log/level/level.go log/level.golog/level/level.go renamed to log/level.go

@@ -1,13 +1,16 @@
-package level
+package log
 
-// Level defines all the available levels we can log at
+// Level defines all the available levels we can log at.
 type Level int32
 
 const (
 	// DebugLevel is the lowest level of logging.
 	// Debug logs are intended for debugging and development purposes.
 	DebugLevel Level = iota + 1
 
+	// InfoLevel is used for user-facing progress and status messages.
+	InfoLevel
+
 	// WarnLevel is used for undesired but relatively expected events,
 	// which may indicate a problem.
 	WarnLevel
@@ -24,14 +27,16 @@ const (
 func (l Level) String() string {
 	switch l {
 	case DebugLevel:
-		return "DEBUG"
+		return "DBG"
+	case InfoLevel:
+		return "INF"
 	case WarnLevel:
-		return "WARN"
+		return "WRN"
 	case ErrorLevel:
-		return "ERROR"
+		return "ERR"
 	case FatalLevel:
-		return "FATAL"
+		return "FTL"
 	default:
-		return "UNKNOWN"
+		return "???"
 	}
 }

log/log.go

@@ -1,44 +1,52 @@
 package log
 
-import (
-	"github.com/moond4rk/hackbrowserdata/log/level"
-)
+import "fmt"
 
 // defaultLogger is the default logger used by the package-level functions.
 var defaultLogger = NewLogger(nil)
 
 func SetVerbose() {
-	defaultLogger.SetLevel(level.DebugLevel)
+	defaultLogger.SetLevel(DebugLevel)
 }
 
 func Debug(args ...any) {
-	defaultLogger.Debug(args...)
+	defaultLogger.logMsg(DebugLevel, fmt.Sprint(args...))
 }
 
 func Debugf(format string, args ...any) {
-	defaultLogger.Debugf(format, args...)
+	defaultLogger.logMsg(DebugLevel, fmt.Sprintf(format, args...))
+}
+
+func Info(args ...any) {
+	defaultLogger.logMsg(InfoLevel, fmt.Sprint(args...))
+}
+
+func Infof(format string, args ...any) {
+	defaultLogger.logMsg(InfoLevel, fmt.Sprintf(format, args...))
 }
 
 func Warn(args ...any) {
-	defaultLogger.Warn(args...)
+	defaultLogger.logMsg(WarnLevel, fmt.Sprint(args...))
 }
 
 func Warnf(format string, args ...any) {
-	defaultLogger.Warnf(format, args...)
+	defaultLogger.logMsg(WarnLevel, fmt.Sprintf(format, args...))
 }
 
 func Error(args ...any) {
-	defaultLogger.Error(args...)
+	defaultLogger.logMsg(ErrorLevel, fmt.Sprint(args...))
 }
 
 func Errorf(format string, args ...any) {
-	defaultLogger.Errorf(format, args...)
+	defaultLogger.logMsg(ErrorLevel, fmt.Sprintf(format, args...))
 }
 
 func Fatal(args ...any) {
-	defaultLogger.Fatal(args...)
+	defaultLogger.logMsg(FatalLevel, fmt.Sprint(args...))
+	osExit(1)
 }
 
 func Fatalf(format string, args ...any) {
-	defaultLogger.Fatalf(format, args...)
+	defaultLogger.logMsg(FatalLevel, fmt.Sprintf(format, args...))
+	osExit(1)
 }