Skip to content

Commit 4c3dd97

Browse files
moonD4rkmoonD4rk
authored
chore: add Go version lint check, modernize issue templates (#557)
- Add go.mod version check in lint workflow (fails if go directive != 1.20) - Add golang.org/x/sys to dependabot ignore list (newer versions require Go 1.21+) - Fix golang.org/x/text ignore comment - Migrate issue templates from markdown to YAML forms: - Update PR template (dev → main, add go.mod checklist item) - Update .gitignore for YAML issue templates
1 parent d8032ac commit 4c3dd97

10 files changed

Lines changed: 207 additions & 73 deletions

File tree

‎.github/ISSUE_TEMPLATE/browser_request.yml‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
name: Browser Support Request
2+
description: Request support for a new browser
3+
labels: ["enhancement", "browser"]
4+
body:
5+
- type: input
6+
id: browser-name
7+
attributes:
8+
label: Browser Name
9+
placeholder: "e.g. Waterfox, Floorp, Whale"
10+
validations:
11+
required: true
12+
13+
- type: dropdown
14+
id: engine
15+
attributes:
16+
label: Browser Engine
17+
options:
18+
- Chromium-based
19+
- Firefox-based
20+
- Other / Unknown
21+
validations:
22+
required: true
23+
24+
- type: dropdown
25+
id: platform
26+
attributes:
27+
label: Platform
28+
multiple: true
29+
options:
30+
- Windows
31+
- macOS
32+
- Linux
33+
validations:
34+
required: true
35+
36+
- type: input
37+
id: data-dir
38+
attributes:
39+
label: User Data Directory
40+
description: The browser's profile/data directory path. You can usually find this at `chrome://version` or `about:support`.
41+
placeholder: "e.g. ~/Library/Application Support/BrowserName/"
42+
validations:
43+
required: false
44+
45+
- type: textarea
46+
id: additional
47+
attributes:
48+
label: Additional Context
49+
description: Any other information about this browser (download link, encryption differences, etc.)
50+
validations:
51+
required: false

‎.github/ISSUE_TEMPLATE/bug_report.md‎

Lines changed: 0 additions & 40 deletions
This file was deleted.

‎.github/ISSUE_TEMPLATE/bug_report.yml‎

Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
1+
name: Bug Report
2+
description: Report a bug to help us improve
3+
labels: ["bug"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
Thanks for taking the time to report a bug! Please fill out the information below.
9+
10+
- type: dropdown
11+
id: os
12+
attributes:
13+
label: Operating System
14+
options:
15+
- Windows
16+
- macOS
17+
- Linux
18+
validations:
19+
required: true
20+
21+
- type: input
22+
id: os-version
23+
attributes:
24+
label: OS Version
25+
placeholder: "e.g. Windows 10 22H2, macOS 14.5, Ubuntu 24.04"
26+
validations:
27+
required: true
28+
29+
- type: dropdown
30+
id: browser
31+
attributes:
32+
label: Browser
33+
options:
34+
- Chrome
35+
- Chrome Beta
36+
- Chromium
37+
- Edge
38+
- Brave
39+
- Opera
40+
- OperaGX
41+
- Vivaldi
42+
- Yandex
43+
- CocCoc
44+
- Arc
45+
- QQ
46+
- 360 ChromeX
47+
- 360 Chrome
48+
- DC Browser
49+
- Sogou Explorer
50+
- Firefox
51+
- Other
52+
validations:
53+
required: false
54+
55+
- type: input
56+
id: browser-version
57+
attributes:
58+
label: Browser Version
59+
placeholder: "e.g. Chrome 135.0.7049.96, Firefox 144.0"
60+
validations:
61+
required: false
62+
63+
- type: textarea
64+
id: description
65+
attributes:
66+
label: Bug Description
67+
description: A clear and concise description of what the bug is.
68+
validations:
69+
required: true
70+
71+
- type: textarea
72+
id: log-output
73+
attributes:
74+
label: Log Output
75+
description: Run `hack-browser-data -v` and paste the output here.
76+
render: shell
77+
validations:
78+
required: false
79+
80+
- type: textarea
81+
id: expected
82+
attributes:
83+
label: Expected vs Actual Behavior
84+
description: What you expected to happen and what actually happened.
85+
validations:
86+
required: false
87+
88+
- type: checkboxes
89+
id: checklist
90+
attributes:
91+
label: Checklist
92+
options:
93+
- label: I have checked the [existing issues](https://github.com/moonD4rk/HackBrowserData/issues) for similar reports.
94+
required: true
95+
- label: I ran `hack-browser-data` with administrator/root privileges.
96+
required: false

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: true
2+
contact_links:
3+
- name: Documentation
4+
url: https://github.com/moonD4rk/HackBrowserData/tree/main/rfcs
5+
about: Read the RFCs for architecture and encryption details.

‎.github/ISSUE_TEMPLATE/feature_request.md‎

Lines changed: 0 additions & 23 deletions
This file was deleted.

‎.github/ISSUE_TEMPLATE/feature_request.yml‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
name: Feature Request
2+
description: Suggest an idea for this project
3+
labels: ["enhancement"]
4+
body:
5+
- type: textarea
6+
id: description
7+
attributes:
8+
label: Feature Description
9+
description: A clear and concise description of the feature.
10+
validations:
11+
required: true
12+
13+
- type: textarea
14+
id: motivation
15+
attributes:
16+
label: Why is this feature needed?
17+
description: Describe the problem this feature would solve or the use case it enables.
18+
validations:
19+
required: true
20+
21+
- type: textarea
22+
id: proposed-solution
23+
attributes:
24+
label: Proposed Solution
25+
description: If you have an idea for how this could be implemented, describe it here.
26+
validations:
27+
required: false
28+
29+
- type: checkboxes
30+
id: checklist
31+
attributes:
32+
label: Checklist
33+
options:
34+
- label: I have checked the [existing issues](https://github.com/moonD4rk/HackBrowserData/issues) for similar requests.
35+
required: true

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
## Proposed changes
1+
## Summary
22

3-
<!-- Describe the overall picture of your modifications to help maintainers understand the pull request. PRs are required to be associated to their related issue tickets or feature request. -->
3+
<!-- Describe the overall picture of your changes. Link to the related issue if applicable. -->
44

5+
Fixes #
56

67
## Checklist
78

8-
<!-- Put an "x" in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. -->
9-
10-
- [ ] Pull request is created against the [dev](https://github.com/moonD4rk/HackBrowserData/tree/dev) branch
11-
- [ ] All checks passed (lint, unit, build tests etc.) with my changes
9+
- [ ] Pull request targets the `main` branch
10+
- [ ] All CI checks pass (lint, test, build)
1211
- [ ] I have added tests that prove my fix is effective or that my feature works
13-
- [ ] I have added necessary documentation (if appropriate)
12+
- [ ] I have added necessary documentation (if appropriate)
13+
- [ ] go.mod directive remains `go 1.20` (do not bump)

‎.github/dependabot.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ updates:
99
ignore:
1010
- dependency-name: "modernc.org/sqlite"
1111
versions: [">=1.32.0"] # v1.32+ requires Go 1.21, project is pinned to Go 1.20
12-
- dependency-name: "golang.org/x/text" # will be removed in upcoming refactoring
12+
- dependency-name: "golang.org/x/text" # indirect dep, newer versions may require Go 1.21+
13+
- dependency-name: "golang.org/x/sys" # newer versions require Go 1.21+
1314
- package-ecosystem: "github-actions"
1415
directory: "/"
1516
schedule:

‎.github/workflows/lint.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,16 @@ jobs:
2323
with:
2424
go-version-file: go.mod
2525

26+
- name: Check Go version constraint
27+
if: matrix.os == 'ubuntu-latest'
28+
run: |
29+
GO_VERSION=$(grep '^go ' go.mod | awk '{print $2}')
30+
if [ "$GO_VERSION" != "1.20" ]; then
31+
echo "::error::go.mod directive must remain 'go 1.20' (Windows 7 support requirement)"
32+
echo "::error::Current value: go $GO_VERSION"
33+
exit 1
34+
fi
35+
2636
- name: Check spelling
2737
if: matrix.os == 'ubuntu-latest'
2838
uses: crate-ci/typos@master

‎.gitignore‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,13 @@
2525
!CONTRIBUTING.md
2626
!CODE_OF_CONDUCT.md
2727
!LOGO.png
28-
!CONTRIBUTORS.svg
2928

3029
# === GitHub ===
3130
!.github/workflows/*.yml
3231
!.github/ISSUE_TEMPLATE/*.md
32+
!.github/ISSUE_TEMPLATE/*.yml
3333
!.github/PULL_REQUEST_TEMPLATE.md
3434
!.github/dependabot.yml
35-
!.github/release-drafter.yml
3635

3736
# === RFCs ===
3837
!rfcs/*.md

0 commit comments

Comments
 (0)