Skip to content

Commit 23037e1

Browse files
authored
Chore: Add CONTRIBUTING.md guidelines and standardized templates (#279)
* chore: Improve GitHub workflows, issue template, and gitignore entries - Add support for manual triggering of build and lint workflows. - Improve bug report template by clarifying prompts and adding checklist and tips for better explanation of issues. - Ignore `.md` files in `.github` and `.github/ISSUE_TEMPLATE` folders. - Add badges for test running and coverage status in README.md. * chore: Add standardized templates to repository - Add pull request and feature request templates to the `.github` folder * docs: Add CONTRIBUTING.md guidelines and update .gitignore. - Update .gitignore to remove exclusions for browsing history files - Add an exclusion for CONTRIBUTING.md in the Community section in .gitignore - Create CONTRIBUTING.md with guidelines for contributors.
1 parent 8a71770 commit 23037e1

9 files changed

Lines changed: 108 additions & 11 deletions

File tree

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 28 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,34 @@ assignees: ''
77

88
---
99

10-
**Describe the bug**
11-
Use `./hack-browser-data -vv` paste result here
10+
## Describe the bug
11+
A clear and concise description of what the bug is.
1212

13+
## Log Output
14+
Please attach or paste the relevant log output. Use `./hack-browser-data -vv` and paste result here.
1315

14-
**Desktop (please complete the following information):**
15-
- OS Name:
16-
- Browser Name:
17-
- Browser Version:
16+
## Expected vs Actual Behavior
17+
Describe what you expected to happen and what actually happened.
1818

19-
**Additional context**
20-
Add any other context about the problem here.
19+
## Desktop (please complete the following information):
20+
Select the operating system(s) you are using:
21+
- [ ] Windows
22+
- [ ] macOS
23+
- [ ] Linux
24+
25+
- OS Version: [e.g. windows 10, macos 10.15.7, ubuntu 20.04]
26+
- OS Architecture: [e.g. 32-bit, 64-bit]
27+
- Browser Name: [e.g. chrome, firefox]
28+
- Browser Version: [e.g. 86.0.4240.111, 82.0.3]
29+
30+
## Additional Details
31+
- [ ] I ran `hack-browser-data` with administrator/root privileges.
32+
33+
## Checklist
34+
- [ ] I have checked the [existing issues](https://github.com/moonD4rk/HackBrowserData/issues) for similar problems.
35+
36+
## Screenshots/Videos
37+
If applicable, add screenshots or videos to help explain your problem.
38+
39+
## Additional context
40+
Add any other context about the problem here.
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
---
2+
name: Feature Request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: enhancement
6+
assignees: ''
7+
8+
---
9+
10+
## Feature Description
11+
A clear and concise description of what the feature is.
12+
13+
## Why is this feature needed?
14+
A clear and concise description of why this feature is needed.
15+
16+
## Checklist
17+
- [ ] I have checked the [existing issues](https://github.com/moonD4rk/HackBrowserData/issues) for similar problems.
18+
19+
## Screenshots/Videos
20+
If applicable, add screenshots or videos to help explain your proposal.
21+
22+
## Additional Context
23+
Add any other context or screenshots about the feature request here.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
## Proposed changes
2+
3+
<!-- Describe the overall picture of your modifications to help maintainers understand the pull request. PRs are required to be associated to their related issue tickets or feature request. -->
4+
5+
6+
## Checklist
7+
8+
<!-- Put an "x" in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. -->
9+
10+
- [ ] Pull request is created against the [dev](https://github.com/moonD4rk/HackBrowserData/tree/dev) branch
11+
- [ ] All checks passed (lint, unit, build tests etc.) with my changes
12+
- [ ] I have added tests that prove my fix is effective or that my feature works
13+
- [ ] I have added necessary documentation (if appropriate)

.github/workflows/build.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
branches:
66
- main
77
pull_request:
8+
workflow_dispatch:
89

910
jobs:
1011
build:

.github/workflows/lint.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on:
44
branches:
55
- main
66
pull_request:
7+
workflow_dispatch:
78
jobs:
89
lint:
910
name: Lint

.github/workflows/unittest.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
on:
2-
[pull_request]
2+
pull_request:
3+
push:
4+
branches:
5+
- main
6+
workflow_dispatch:
37

48
name: run tests
59
jobs:

.gitignore

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,4 +196,9 @@ hack-browser-data
196196
!/browsingdata/history/history_test.go
197197

198198
# github action
199-
!/.github/workflows/unittest.yml
199+
!/.github/workflows/unittest.yml
200+
!/.github/ISSUE_TEMPLATE/*.md
201+
!/.github/*.md
202+
203+
# Community
204+
!CONTRIBUTING.md

CONTRIBUTING.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
# Contributing to HackBrowserData
2+
3+
We appreciate your interest in contributing to the HackBrowserData! This document provides some basic guidelines for contributors.
4+
5+
## Getting Started
6+
7+
- Always base your work from the `dev` branch, which is the development branch with the latest code.
8+
- Before creating a Pull Request (PR), make sure there is a corresponding issue for your contribution. If there isn't one already, please create one.
9+
- Include the problem description in the issue.
10+
11+
## Pull Requests
12+
13+
When creating a PR, please follow these guidelines:
14+
15+
- Link your PR to the corresponding issue.
16+
- Provide context in the PR description to help reviewers understand the changes. The more information you provide, the faster the review process will be.
17+
- Include an example of running the tool with the changed code, if applicable. Provide 'before' and 'after' examples if possible.
18+
- Include steps for functional testing or replication.
19+
- If you're adding a new feature, make sure to include unit tests.
20+
21+
## Code Style
22+
23+
Please adhere to the existing coding style for consistency.
24+
25+
## Questions
26+
27+
If you have any questions or need further guidance, please feel free to ask in the issue or PR, or [reach out to the maintainers](mailto:[email protected]).
28+
29+
Thank you for your contribution!
30+

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
# HackBrowserData
77

8-
[![Lint](https://github.com/moonD4rk/HackBrowserData/actions/workflows/lint.yml/badge.svg)](https://github.com/moonD4rk/HackBrowserData/actions/workflows/lint.yml) [![build](https://github.com/moonD4rk/HackBrowserData/actions/workflows/build.yml/badge.svg)](https://github.com/moonD4rk/HackBrowserData/actions/workflows/build.yml) [![Release](https://github.com/moonD4rk/HackBrowserData/actions/workflows/release.yml/badge.svg)](https://github.com/moonD4rk/HackBrowserData/actions/workflows/release.yml)
8+
[![Lint](https://github.com/moonD4rk/HackBrowserData/actions/workflows/lint.yml/badge.svg)](https://github.com/moonD4rk/HackBrowserData/actions/workflows/lint.yml) [![build](https://github.com/moonD4rk/HackBrowserData/actions/workflows/build.yml/badge.svg)](https://github.com/moonD4rk/HackBrowserData/actions/workflows/build.yml) [![Release](https://github.com/moonD4rk/HackBrowserData/actions/workflows/release.yml/badge.svg)](https://github.com/moonD4rk/HackBrowserData/actions/workflows/release.yml) [![run tests](https://github.com/moonD4rk/HackBrowserData/actions/workflows/unittest.yml/badge.svg)](https://github.com/moonD4rk/HackBrowserData/actions/workflows/unittest.yml) [![Coverage Status](https://coveralls.io/repos/github/moonD4rk/HackBrowserData/badge.svg)](https://coveralls.io/github/moonD4rk/HackBrowserData)
99

1010
[中文说明](https://github.com/moonD4rk/HackBrowserData/blob/master/README_ZH.md)
1111

0 commit comments

Comments
 (0)