[update] Use culture-insensitive string comparisons. (#663)

It performs better.

Co-authored-by: Min Huang <[email protected]>

Author: rolfbjarne

mdoc/Mono.Documentation/MDocUpdater.cs

@@ -990,10 +990,10 @@ private void AddIndexAssembly (AssemblyDefinition assembly, XmlElement parent, F
             {
                 XmlElement pubkey = WriteElement (index_assembly, "AssemblyPublicKey");
                 var key = new StringBuilder (name.PublicKey.Length * 3 + 2);
-                key.Append ("[");
+                key.Append ('[');
                 foreach (byte b in name.PublicKey)
                     key.AppendFormat ("{0,2:x2} ", b);
-                key.Append ("]");
+                key.Append (']');
                 pubkey.InnerText = key.ToString ();
                 index_assembly.AppendChild (pubkey);
             }
@@ -1267,7 +1267,7 @@ public override int Compare (XmlNode x, XmlNode y)
 
             static string GetVersion (string v)
             {
-                int n = v.IndexOf ("x");
+                int n = v.IndexOf ('x');
                 if (n < 0)
                     return v;
                 return v.Substring (0, n - 1);
@@ -2005,14 +2005,14 @@ public override int Compare (XmlNode x, XmlNode y)
                 // generic methods *end* with '>'
                 // it's possible for explicitly implemented generic interfaces to
                 // contain <...> without being a generic method
-                if ((!xMemberName.EndsWith (">") || !yMemberName.EndsWith (">")) &&
+                if ((!xMemberName.EndsWith (">", StringComparison.Ordinal) || !yMemberName.EndsWith (">", StringComparison.Ordinal)) &&
                         (r = xMemberName.CompareTo (yMemberName)) != 0)
                     return r;
 
                 int lt;
-                if ((lt = xMemberName.IndexOf ("<")) >= 0)
+                if ((lt = xMemberName.IndexOf ('<')) >= 0)
                     xMemberName = xMemberName.Substring (0, lt);
-                if ((lt = yMemberName.IndexOf ("<")) >= 0)
+                if ((lt = yMemberName.IndexOf ('<')) >= 0)
                     yMemberName = yMemberName.Substring (0, lt);
                 if ((r = xMemberName.CompareTo (yMemberName)) != 0)
                     return r;
@@ -4186,7 +4186,7 @@ private void MakeParameters (XmlElement root, MemberReference mi, FrameworkTypeE
 
         public static string GetDocParameterType (TypeReference type, bool useTypeProjection = false)
         {
-            var typename = GetDocTypeFullName (type, useTypeProjection).Replace ("@", "&");
+            var typename = GetDocTypeFullName (type, useTypeProjection).Replace ('@', '&');
 
             if (useTypeProjection || string.IsNullOrEmpty(typename))
             {
@@ -4337,11 +4337,11 @@ private static void AddGenericParameter(StringBuilder sb, MethodDefinition mb)
                 IList<GenericParameter> typeParams = mb.GenericParameters;
                 if (typeParams.Count > 0)
                 {
-                    sb.Append("<");
+                    sb.Append('<');
                     sb.Append(typeParams[0].Name);
                     for (int i = 1; i < typeParams.Count; ++i)
-                        sb.Append(",").Append(typeParams[i].Name);
-                    sb.Append(">");
+                        sb.Append(',').Append(typeParams[i].Name);
+                    sb.Append('>');
                 }
             }
         }
@@ -4420,7 +4420,7 @@ internal static string GetXPathForMember (DocumentationMember member)
                 {
                     xpath.Append (" and Parameter [").Append (i + 1).Append ("]/@Type=\"");
                     xpath.Append (member.Parameters[i]);
-                    xpath.Append ("\"");
+                    xpath.Append ('"');
                 }
                 xpath.Append ("]/..");
             }
@@ -4447,7 +4447,7 @@ public static string GetXPathForMember (XPathNavigator member)
                     ++i;
                     xpath.Append (" and Parameter [").Append (i).Append ("]/@Type=\"");
                     xpath.Append (parameters.Current.Value);
-                    xpath.Append ("\"");
+                    xpath.Append ('"');
                 }
                 xpath.Append ("]/..");
             }
@@ -4479,7 +4479,7 @@ public static string GetXPathForMember (MemberReference member)
                 {
                     xpath.Append (" and Parameter [").Append (i + 1).Append ("]/@Type=\"");
                     xpath.Append (GetDocParameterType (parameters[i].ParameterType));
-                    xpath.Append ("\"");
+                    xpath.Append ('"');
                 }
                 xpath.Append ("]/..");
             }