From 650705332fb56b267a96973c1dabacb7214f9adb Mon Sep 17 00:00:00 2001 From: bailey Date: Fri, 14 Mar 2025 11:12:03 -0600 Subject: [PATCH 1/2] skip flaky tests --- test/integration/node-specific/abort_signal.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/integration/node-specific/abort_signal.test.ts b/test/integration/node-specific/abort_signal.test.ts index 7aa59a88ff6..a0b65b4765f 100644 --- a/test/integration/node-specific/abort_signal.test.ts +++ b/test/integration/node-specific/abort_signal.test.ts @@ -932,7 +932,7 @@ describe('AbortSignal support', () => { await clearFailPoint(this.configuration); }); - it(`rejects findOne`, async () => { + it.skip(`rejects findOne`, async () => { client.on( 'commandStarted', // Abort a bit after find has started: @@ -945,7 +945,7 @@ describe('AbortSignal support', () => { expect(end - start).to.be.lessThan(10); // shouldn't wait for the blocked connection expect(result).to.be.instanceOf(DOMException); - }); + }).skipReason = 'TODO(NODE-6833): fix flaky test'; }); describe('when a signal passed to db.command() is aborted', failPointMetadata, () => { From 4435480e8b1a902153d37cd550468e4e1474f4fb Mon Sep 17 00:00:00 2001 From: Neal Beeken Date: Mon, 17 Mar 2025 11:15:39 -0400 Subject: [PATCH 2/2] chore: bump duration --- test/integration/node-specific/abort_signal.test.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/test/integration/node-specific/abort_signal.test.ts b/test/integration/node-specific/abort_signal.test.ts index a0b65b4765f..40ad3b3414d 100644 --- a/test/integration/node-specific/abort_signal.test.ts +++ b/test/integration/node-specific/abort_signal.test.ts @@ -932,7 +932,7 @@ describe('AbortSignal support', () => { await clearFailPoint(this.configuration); }); - it.skip(`rejects findOne`, async () => { + it(`rejects findOne`, async () => { client.on( 'commandStarted', // Abort a bit after find has started: @@ -942,10 +942,11 @@ describe('AbortSignal support', () => { const start = performance.now(); const result = await collection.findOne({}, { signal }).catch(error => error); const end = performance.now(); - expect(end - start).to.be.lessThan(10); // shouldn't wait for the blocked connection + // TODO(NODE-6833): This duration was bumped from 10 to 40 to reduce flakiness, if this fails again investigate it. + expect(end - start).to.be.lessThan(40); // shouldn't wait for the blocked connection expect(result).to.be.instanceOf(DOMException); - }).skipReason = 'TODO(NODE-6833): fix flaky test'; + }); }); describe('when a signal passed to db.command() is aborted', failPointMetadata, () => {