types(ModifyResult): update lastErrorObject#4493
Closed
moshfeu wants to merge 1 commit intomongodb:mainfrom
Closed
types(ModifyResult): update lastErrorObject#4493moshfeu wants to merge 1 commit intomongodb:mainfrom
moshfeu wants to merge 1 commit intomongodb:mainfrom
Conversation
Contributor
|
@moshfeu Are you intending to open this PR? |
Author
|
I will do it eventually :) I just didn't have the time to go through test steps in "Double check the following". |
Contributor
|
@moshfeu Okay! That's fine, take your time. But would you mind closing this PR until you're ready to open it for review? |
Author
|
Sure, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes a modification to the
ModifyResultinterface in thesrc/collection.tsfile to provide more detailed information about the last error object.Changes to
ModifyResultinterface:src/collection.ts: Updated thelastErrorObjectproperty in theModifyResultinterface to include more specific fields:n,updatedExisting, andupserted.https://www.mongodb.com/docs/manual/reference/command/findAndModify/#lasterrorobject
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript