remove dependency on heapsnapshot

Author: baileympearson

test/integration/node-specific/resource_clean_up.test.ts

@@ -17,7 +17,7 @@ const MB_PERMITTED_OFFSET = 5;
 describe('Driver Resources', () => {
   let startingMemoryUsed;
   let endingMemoryUsed;
-  let heap;
+  let clientsInMemory;
 
   beforeEach(function () {
     if (globalThis.AbortController == null) {
@@ -34,12 +34,6 @@ describe('Driver Resources', () => {
 
   context('on MongoClient.close()', () => {
     before('create leak reproduction script', async function () {
-      if (process.version.includes('v24')) {
-        if (this.test) {
-          this.test.skipReason = 'TODO(NODE-6945): Fix v24 heap snapshot parsing';
-        }
-        this.test?.skip();
-      }
       if (globalThis.AbortController == null || typeof this.configuration.serverApi === 'string') {
         return;
       }
@@ -58,7 +52,7 @@ describe('Driver Resources', () => {
 
       startingMemoryUsed = res.startingMemoryUsed;
       endingMemoryUsed = res.endingMemoryUsed;
-      heap = res.heap;
+      clientsInMemory = res.clientsInMemory;
     });
 
     describe('ending memory usage', () => {
@@ -77,11 +71,10 @@ describe('Driver Resources', () => {
 
     describe('ending heap snapshot', () => {
       it('has 0 MongoClients in memory', async () => {
-        const clients = heap.nodes.filter(n => n.name === 'MongoClient' && n.type === 'object');
         // lengthOf crashes chai b/c it tries to print out a gigantic diff
         expect(
-          clients.length,
-          `expected no MongoClients in the heapsnapshot, found ${clients.length}`
+          clientsInMemory,
+          `expected no MongoClients in the heapsnapshot, found ${clientsInMemory}`
         ).to.equal(0);
       });
     });

test/integration/node-specific/resource_tracking_script_builder.ts

@@ -106,7 +106,6 @@ export async function runScriptAndReturnHeapInfo(
   };
   log('starting');
   const scriptName = `${name}.cjs`;
-  const heapsnapshotFile = `${name}.heapsnapshot.json`;
 
   const scriptContent = await testScriptFactory(
     name,
@@ -148,28 +147,27 @@ export async function runScriptAndReturnHeapInfo(
   const startingMemoryUsed = starting.value[0].startingMemoryUsed;
   const endingMemoryUsed = ending.value[0].endingMemoryUsed;
 
+  const {
+    value: [{ clientsInMemory }]
+  } = await messages.next();
+
   // make sure the process ended
   const [exitCode] = await willClose;
 
   log('child process closed.');
 
   expect(exitCode, 'process should have exited with zero').to.equal(0);
 
-  const heap = await readFile(heapsnapshotFile, { encoding: 'utf8' }).then(c =>
-    parseSnapshot(JSON.parse(c))
-  );
-
   log('done.');
 
   // If any of the above throws we won't reach these unlinks that clean up the created files.
   // This is intentional so that when debugging the file will still be present to check it for errors
   await unlink(scriptName);
-  await unlink(heapsnapshotFile);
 
   return {
     startingMemoryUsed,
     endingMemoryUsed,
-    heap
+    clientsInMemory
   };
 }
 

test/tools/fixtures/heap_resource_script.in.js

@@ -59,11 +59,16 @@ async function main() {
   process.send({ endingMemoryUsed });
   log('second message sent.');
 
-  const start = now();
-  v8.writeHeapSnapshot(`${name}.heapsnapshot.json`);
-  const end = now();
+  const clientsInMemory = v8.queryObjects(MongoClient);
 
-  log(`heap snapshot written in ${end - start}ms. script exiting`);
+  process.send({ clientsInMemory });
+
+  log('clients instances in memory sent.');
+  // const start = now();
+  // v8.writeHeapSnapshot(`${name}.heapsnapshot.json`);
+  // const end = now();
+
+  // log(`heap snapshot written in ${end - start}ms. script exiting`);
 }
 
 main()