lint + add skip reasons

Author: baileympearson

global.d.ts

@@ -120,7 +120,7 @@ declare global {
        * beforeEach(() => {
        *   if ('some condition') {
        *     this.currentTest.skipReason = 'requires <run condition> to run';
-       *     this;
+       *     this.skip();
        *   }
        * });
        * ```

test/integration/change-streams/change_stream.test.ts

@@ -1273,7 +1273,7 @@ describe('Change Streams', function () {
         'changeStream should close if cursor id for initial aggregate is Long.ZERO',
         {
           requires: {
-            predicate: () => (process.env.SSL === 'ssl' ? 'test requries no TLS' : true)
+            tls: 'disabled'
           }
         },
         async function () {

test/integration/connection-monitoring-and-pooling/connection_monitoring_and_pooling.spec.test.ts

@@ -39,7 +39,7 @@ const INTERRUPT_IN_USE_SKIPPED_TESTS: SkipDescription[] = [
   }
 ];
 
-describe('Connection Monitoring and Pooling Spec Tests (Integration) - cmap-format', function () {
+describe.only('Connection Monitoring and Pooling Spec Tests (Integration) - cmap-format', function () {
   const tests: CmapTest[] = loadSpecTests('connection-monitoring-and-pooling', 'cmap-format');
 
   runCmapTestSuite(tests, {

test/integration/retryable-reads/retryable_reads.spec.test.ts

@@ -27,7 +27,7 @@ describe('Retryable Reads (unified)', function () {
       }
     }
 
-    if (isTLSEnabled) return 'TODO(NODE-XXXX): ...';
+    if (isTLSEnabled) return 'TODO(NODE-7408): fix these tests when TLS is enabled';
 
     return false;
   });

test/integration/retryable-writes/retryable_writes.spec.test.ts

@@ -4,7 +4,8 @@ import { loadSpecTests } from '../../spec';
 import { isTLSEnabled } from '../../tools/runner/filters/tls_filter';
 import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner';
 
-const filter = () => (isTLSEnabled ? 'TODO(NODE-XXXX): ...' : false);
+const filter = () =>
+  isTLSEnabled ? 'TODO(NODE-7408): fix these tests when TLS is enabled' : false;
 describe('Retryable Writes (unified)', function () {
   runUnifiedSuite(loadSpecTests(path.join('retryable-writes', 'unified')), filter);
 });

test/tools/cmap_spec_runner.ts

@@ -532,14 +532,7 @@ export function runCmapTestSuite(
             throw new Error('Failed to retrieve server for test');
           }
 
-          const poolOptions = {
-            ...(this.configuration.isLoadBalanced ? { loadBalanced: true } : {}),
-            ...getTLSOptions()
-          };
-
-          delete poolOptions.tls;
-
-          console.error({ poolOptions });
+          const poolOptions = this.configuration.isLoadBalanced ? { loadBalanced: true } : {};
 
           threadContext = new ThreadContext(server, hostAddress, poolOptions, {
             injectPoolStats: !!options?.injectPoolStats
@@ -566,6 +559,7 @@ export function runCmapTestSuite(
         test.description,
         {
           requires: {
+            // TODO(NODE-7408): fix these tests when TLS is enabled
             tls: 'disabled'
           }
         },