Skip to content

Commit 9635d93

Browse files
tadjik1Copilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
1 parent d992590 commit 9635d93

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

test/manual/kerberos.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe('Kerberos', function () {
6464
`${krb5Uri}&authMechanismProperties=SERVICE_NAME:mongodb,CANONICALIZE_HOST_NAME:forward&maxPoolSize=1`
6565
);
6666
await client.connect();
67-
expect(resolveStub.withArgs(sinon.match.any, 'CNAME')).to.be.calledOnceWith(host);
67+
expect(resolveStub.withArgs(sinon.match.any, 'CNAME')).to.be.calledOnceWith(host, 'CNAME');
6868
await verifyKerberosAuthentication(client);
6969
});
7070
});
@@ -169,7 +169,7 @@ describe('Kerberos', function () {
169169

170170
context('when the cname lookup is empty', function () {
171171
beforeEach(function () {
172-
resolveStub.withArgs(sinon.match.string, 'CNAME').rejects([]);
172+
resolveStub.withArgs(sinon.match.string, 'CNAME').resolves([]);
173173
});
174174

175175
it('authenticates with a fallback host name', async function () {

test/unit/sdam/srv_polling.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ describe('Mongos SRV Polling', function () {
103103
clearTimeout(poller._timeout);
104104

105105
expect(dns.promises.resolve).to.have.been.calledOnce.and.to.have.been.calledWith(
106-
`_mongodb._tcp.${SRV_HOST}`
106+
`_mongodb._tcp.${SRV_HOST}`,
107+
'SRV'
107108
);
108109
});
109110

0 commit comments

Comments
 (0)