misc fixes

- fix lint configuration to restrict imports from src
- auto fix import order in all test files
- fix error tests, which were failing and skipped
- unskip driver import tests

Author: baileympearson

.eslintrc.json

@@ -225,7 +225,8 @@
           {
             "patterns": [
               "**/../lib/**",
-              "mongodb-mock-server"
+              "mongodb-mock-server",
+              "**/../src/**"
             ]
           }
         ]

test/mongodb.ts

@@ -1,3 +1,6 @@
+// As the centralized import for all src code for tests, we intentionally import from `src` in this file.
+/* eslint-disable @typescript-eslint/no-restricted-imports */
+
 export * from '../src/admin';
 export * from '../src/bson';
 export * from '../src/bulk/common';
@@ -111,6 +114,7 @@ export * from '../src/operations/update';
 export * from '../src/operations/validate_collection';
 export * from '../src/read_concern';
 export * from '../src/read_preference';
+export * from '../src/runtime_adapters';
 export * from '../src/sdam/common';
 export * from '../src/sdam/events';
 export * from '../src/sdam/monitor';
@@ -127,4 +131,3 @@ export * from '../src/timeout';
 export * from '../src/transactions';
 export * from '../src/utils';
 export * from '../src/write_concern';
-export * from '../src/runtime_adapters';

test/tools/utils.ts

@@ -17,13 +17,13 @@ import {
   type HostAddress,
   MongoClient,
   type MongoClientOptions,
-  type Runtime,
-  type ServerApiVersion,
-  type TopologyOptions,
   OP_MSG,
   processTimeMS,
+  resolveRuntimeAdapters,
+  type Runtime,
+  type ServerApiVersion,
   Topology,
-  resolveRuntimeAdapters
+  type TopologyOptions
 } from '../mongodb';
 import { type TestConfiguration } from './runner/config';
 import { isTLSEnabled } from './runner/filters/tls_filter';

test/unit/assorted/imports.test.ts

@@ -15,7 +15,7 @@ function* walk(root) {
   }
 }
 
-describe.skip('importing mongodb driver', () => {
+describe('importing mongodb driver', () => {
   const sourceFiles = walk(path.resolve(__dirname, '../../../src'));
 
   for (const sourceFile of sourceFiles) {

test/unit/client-side-encryption/providers/credentialsProvider.test.ts

@@ -4,6 +4,7 @@ import * as process from 'process';
 import * as sinon from 'sinon';
 
 // Intentionally import from src, because we need to stub the `get()` function.
+// eslint-disable-next-line @typescript-eslint/no-restricted-imports
 import * as utils from '../../../../src/utils';
 import {
   AWSSDKCredentialProvider,

test/unit/cmap/handshake/client_metadata.test.ts

@@ -6,14 +6,13 @@ import * as sinon from 'sinon';
 import { inspect } from 'util';
 
 import { version as NODE_DRIVER_VERSION } from '../../../../package.json';
-import { runtime } from '../../../tools/utils';
-
 import {
   getFAASEnv,
   LimitedSizeDocument,
   makeClientMetadata,
   MongoInvalidArgumentError
 } from '../../../mongodb';
+import { runtime } from '../../../tools/utils';
 describe('client metadata module', () => {
   afterEach(() => sinon.restore());
 

test/unit/commands.test.ts

@@ -1,6 +1,7 @@
 import { expect } from 'chai';
 import * as sinon from 'sinon';
 
+// eslint-disable-next-line @typescript-eslint/no-restricted-imports
 import * as compression from '../../src/cmap/wire_protocol/compression';
 import {
   compress,

test/unit/error.test.ts

@@ -1,7 +1,11 @@
 import { expect } from 'chai';
 import { setTimeout } from 'timers';
 
+// Exception to the import from mongodb rule we're unit testing our public Errors API
+// eslint-disable-next-line @typescript-eslint/no-restricted-imports
 import * as importsFromErrorSrc from '../../src/error';
+// eslint-disable-next-line @typescript-eslint/no-restricted-imports
+import * as importsFromEntryPoint from '../../src/index';
 import {
   DeprioritizedServers,
   isHello,
@@ -25,31 +29,29 @@ import {
   needsRetryableWriteLabel,
   NODE_IS_RECOVERING_ERROR_MESSAGE,
   ns,
-  PoolClosedError,
+  PoolClosedError as MongoPoolClosedError,
   RunCommandOperation,
   setDifference,
   TimeoutContext,
   type Topology,
   type TopologyDescription,
   type TopologyOptions,
-  WaitQueueTimeoutError
+  WaitQueueTimeoutError as MongoWaitQueueTimeoutError
 } from '../mongodb';
-// Exception to the import from mongodb rule we're unit testing our public Errors API
-import * as importsFromEntryPoint from '../mongodb';
 import { ReplSetFixture } from '../tools/common';
 import { cleanup } from '../tools/mongodb-mock/index';
 import { topologyWithPlaceholderClient } from '../tools/utils';
 
-describe.skip('MongoErrors', () => {
+describe('MongoErrors', () => {
   let errorClassesFromEntryPoint = Object.fromEntries(
     Object.entries(importsFromEntryPoint).filter(
       ([key, value]) => key.endsWith('Error') && value.toString().startsWith('class')
     )
   ) as any;
   errorClassesFromEntryPoint = {
     ...errorClassesFromEntryPoint,
-    PoolClosedError,
-    WaitQueueTimeoutError
+    MongoPoolClosedError,
+    MongoWaitQueueTimeoutError
   };
 
   const errorClassesFromErrorSrc = Object.fromEntries(