Refactoring: remove the broken shouldAttemptToRetryWriteAndAddRetryableLabel method

Author: stIncMale

driver-core/src/main/com/mongodb/internal/operation/ClientBulkWriteOperation.java

@@ -130,8 +130,8 @@
 import static com.mongodb.internal.operation.AsyncOperationHelper.withAsyncSourceAndConnection;
 import static com.mongodb.internal.operation.BulkWriteBatch.logWriteModelDoesNotSupportRetries;
 import static com.mongodb.internal.operation.CommandOperationHelper.commandWriteConcern;
+import static com.mongodb.internal.operation.CommandOperationHelper.getWriteAttemptFailureNotToBeRetriedOrAddRetryableLabel;
 import static com.mongodb.internal.operation.CommandOperationHelper.initialRetryState;
-import static com.mongodb.internal.operation.CommandOperationHelper.shouldAttemptToRetryWriteAndAddRetryableLabel;
 import static com.mongodb.internal.operation.CommandOperationHelper.transformWriteException;
 import static com.mongodb.internal.operation.OperationHelper.isRetryableWrite;
 import static com.mongodb.internal.operation.SyncOperationHelper.cursorDocumentToBatchCursor;
@@ -321,7 +321,7 @@ private Integer executeBatch(
             // The server does not have a chance to add "RetryableWriteError" label to `e`,
             // and if it is the last attempt failure, `RetryingSyncSupplier` also may not have a chance
             // to add the label. So we do that explicitly.
-            shouldAttemptToRetryWriteAndAddRetryableLabel(retryState, mongoException);
+            getWriteAttemptFailureNotToBeRetriedOrAddRetryableLabel(retryState, mongoException);
             resultAccumulator.onBulkWriteCommandErrorWithoutResponse(mongoException);
             throw mongoException;
         }
@@ -386,7 +386,7 @@ private void executeBatchAsync(
                 // The server does not have a chance to add "RetryableWriteError" label to `e`,
                 // and if it is the last attempt failure, `RetryingSyncSupplier` also may not have a chance
                 // to add the label. So we do that explicitly.
-                shouldAttemptToRetryWriteAndAddRetryableLabel(retryState, mongoException);
+                getWriteAttemptFailureNotToBeRetriedOrAddRetryableLabel(retryState, mongoException);
                 resultAccumulator.onBulkWriteCommandErrorWithoutResponse(mongoException);
                 c.completeExceptionally(mongoException);
             } else {

driver-core/src/main/com/mongodb/internal/operation/CommandOperationHelper.java

@@ -186,15 +186,11 @@ static boolean loggingShouldAttemptToRetryWriteAndAddRetryableLabel(final RetryS
         return decision;
     }
 
-    static boolean shouldAttemptToRetryWriteAndAddRetryableLabel(final RetryState retryState, final Throwable attemptFailure) {
-        return getWriteAttemptFailureNotToBeRetriedOrAddRetryableLabel(retryState, attemptFailure) != null;
-    }
-
     /**
      * @return {@code null} if the decision is {@code true}. Otherwise, returns the {@link Throwable} that must not be retried.
      */
     @Nullable
-    private static Throwable getWriteAttemptFailureNotToBeRetriedOrAddRetryableLabel(final RetryState retryState, final Throwable attemptFailure) {
+    static Throwable getWriteAttemptFailureNotToBeRetriedOrAddRetryableLabel(final RetryState retryState, final Throwable attemptFailure) {
         Throwable failure = attemptFailure instanceof ResourceSupplierInternalException ? attemptFailure.getCause() : attemptFailure;
         boolean decision = false;
         MongoException exceptionRetryableRegardlessOfCommand = null;