Skip to content

Commit ba635a1

Browse files
No shell interpreter on Windows
1 parent 49cf995 commit ba635a1

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

.github/scripts/utils.mjs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export function buildLibmongocryptDownloadUrl(ref, platform) {
3838
const [major, minor, _patch] = ref.split('.');
3939

4040
// Just a note: it may appear that this logic _doesn't_ support patch releases but it actually does.
41-
// libmongocrypt's creates release branches for minor releases in the form `r<major>.<minor>`.
41+
// libmongocrypt's creates release branches for minor releases in the form `r<major>.<minor>`.
4242
// Any patches made to this branch are committed as tags in the form <major>.<minor>.<patch>.
4343
// So, the branch that is used for the AWS s3 upload is `r<major>.<minor>` and the commit hash
4444
// is the commit hash we parse from the `getCommitFromRef()` (which handles switching to git tags and
@@ -49,7 +49,7 @@ export function buildLibmongocryptDownloadUrl(ref, platform) {
4949
}
5050

5151
// just a note here - `master` refers to the branch, the hash is the commit on that branch.
52-
// if we ever need to download binaries from a non-master branch (or non-release branch),
52+
// if we ever need to download binaries from a non-master branch (or non-release branch),
5353
// this will need to be modified somehow.
5454
return `https://mciuploads.s3.amazonaws.com/libmongocrypt/${platform}/master/${hash}/libmongocrypt.tar.gz`;
5555
}
@@ -81,7 +81,6 @@ export async function run(command, args = [], options = {}) {
8181
const commandDetails = `+ ${command} ${args.join(' ')}${options.cwd ? ` (in: ${options.cwd})` : ''}`;
8282
console.error(commandDetails);
8383
const proc = spawn(command, args, {
84-
shell: process.platform === 'win32',
8584
stdio: 'inherit',
8685
cwd: resolveRoot('.'),
8786
...options
@@ -100,7 +99,7 @@ function getLibc() {
10099
/**
101100
* executes `ldd --version`. on Alpine linux, `ldd` and `ldd --version` return exit code 1 and print the version
102101
* info to stderr, but on other platforms, `ldd --version` prints to stdout and returns exit code 0.
103-
*
102+
*
104103
* So, this script works on both by return stderr if the command returns a non-zero exit code, otherwise stdout.
105104
*/
106105
function lddVersion() {

0 commit comments

Comments
 (0)