Complete: SOLV-41 Fix error-case fallbacks in lower_literal_type

Hardened the lower_literal_type function to propagate errors instead of
silently accepting invalid code with ANY type:

- Changed operand retrieval failure from ANY to ERROR (line 1914)
- Changed unknown operand kind fallback from ANY to ERROR (line 1957)
- Changed missing unary expression data fallback from ANY to ERROR (line 1960)
- Changed unknown literal kind fallback from ANY to ERROR (line 1963)
- Changed missing literal node fallback from ANY to ERROR (line 1966)
- Changed missing literal type data fallback from ANY to ERROR (line 1969)

This continues the work from SOLV-40 to align with PROJECT_DIRECTION.md
directive to propagate errors and reduce unsoundness.

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: mohsen1

WORKER_11_TASK_LIST.md

@@ -7,6 +7,14 @@
 (none yet)
 
 ## Completed
+- [x] **SOLV-41: Fix error-case fallbacks in lower.rs**
+  - Changed operand retrieval failure from ANY to ERROR (lower.rs:1914)
+  - Changed unknown operand kind fallback from ANY to ERROR (lower.rs:1957)
+  - Changed missing unary expression data fallback from ANY to ERROR (lower.rs:1960)
+  - Changed unknown literal kind fallback from ANY to ERROR (lower.rs:1963)
+  - Changed missing literal node fallback from ANY to ERROR (lower.rs:1966)
+  - Changed missing literal type data fallback from ANY to ERROR (lower.rs:1969)
+  - Hardened lower_literal_type function to propagate errors instead of silently accepting
 - [x] **SOLV-40: Fix type lowering fallback and repair broken merges**
   - Changed catch-all `_ => TypeId::ANY` to `_ => TypeId::ERROR` in lower.rs:448
   - This aligns with PROJECT_DIRECTION.md directive to propagate errors

wasm/src/solver/lower.rs

@@ -1911,7 +1911,7 @@ impl<'a> TypeLowering<'a> {
                         if let Some(unary) = self.arena.get_unary_expr(literal_node) {
                             let op = unary.operator;
                             let Some(operand_node) = self.arena.get(unary.operand) else {
-                                return TypeId::ANY;
+                                return TypeId::ERROR; // Propagate error for missing operand
                             };
                             match operand_node.kind {
                                 k if k == SyntaxKind::NumericLiteral as u16 => {
@@ -1954,19 +1954,19 @@ impl<'a> TypeLowering<'a> {
                                         TypeId::BIGINT
                                     }
                                 }
-                                _ => TypeId::ANY,
+                                _ => TypeId::ERROR, // Propagate error for unknown operand kind
                             }
                         } else {
-                            TypeId::ANY
+                            TypeId::ERROR // Propagate error for missing unary expression data
                         }
                     }
-                    _ => TypeId::ANY,
+                    _ => TypeId::ERROR, // Propagate error for unknown literal kind
                 }
             } else {
-                TypeId::ANY
+                TypeId::ERROR // Propagate error for missing literal node
             }
         } else {
-            TypeId::ANY
+            TypeId::ERROR // Propagate error for missing literal type data
         }
     }