Complete Bookmarks context menu with full target action parity (#4810)

* Initial plan

* feat: complete Bookmarks context menu with full target action parity (#4788)

- Enrich BookmarkNode.contextValue with target metadata (canBuild, canRun,
  isDefault, isLaunch, specific type) from the live source TargetNode
- Fix setDefaultTarget, setLaunchTarget, revealInCMakeLists handlers to
  accept BookmarkNode via resolveTargetNode
- Add missing bookmark context menu entries: Set Build Target, Set
  Launch/Debug Target, Open CMakeLists.txt, Run Utility Target
- Refine existing bookmark menu entries with proper when clauses

Co-authored-by: hanniavalera <[email protected]>

* fixing bug that viewItem =~ /isDefault=/ is too broad and matches isDefault=false on unresolved bookmarks

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: hanniavalera <[email protected]>
Co-authored-by: Copilot Autofix powered by AI <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -13,6 +13,7 @@ Features:
 - Add `cmake.setBuildTargetSameAsLaunchTarget` setting to automatically set the build target when the launch/debug target is changed. [#4519](https://github.com/microsoft/vscode-cmake-tools/pull/4519) [@nikita-karatun](https://github.com/nikita-karatun)
 - Add `cmake.additionalBuildProblemMatchers` setting to define custom problem matchers for build output. Supports tools like clang-tidy, PCLint Plus, cppcheck, or custom scripts integrated via `add_custom_command`/`add_custom_target`. [#4077](https://github.com/microsoft/vscode-cmake-tools/issues/4077)
 - Support `targetName` argument for launch-target command substitutions (`cmake.launchTargetPath`, etc.) via `${input:...}` variables, enabling build-before-run for non-active executable targets without changing the active launch target. [#4656](https://github.com/microsoft/vscode-cmake-tools/issues/4656)
+- Complete Bookmarks context menu with "Set Build Target", "Set Launch/Debug Target", "Open CMakeLists.txt", and "Run Utility Target" actions to match the Project Outline. [#4788](https://github.com/microsoft/vscode-cmake-tools/issues/4788)
 - Relax `intelliSenseMode` validation in CMake Presets. [#4815](https://github.com/microsoft/vscode-cmake-tools/issues/4815) [@halflifefan](https://github.com/halflifefan)
 
 Improvements:

package.json

@@ -2116,18 +2116,38 @@
         },
         {
           "command": "cmake.outline.buildTarget",
-          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet",
-          "group": "bookmarkActions@1"
+          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet && viewItem =~ /canBuild=true/",
+          "group": "1_targetActions@1"
+        },
+        {
+          "command": "cmake.outline.runUtilityTarget",
+          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet && viewItem =~ /canRun=true/",
+          "group": "1_targetActions@2"
         },
         {
           "command": "cmake.outline.debugTarget",
-          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet",
-          "group": "bookmarkActions@2"
+          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet && viewItem =~ /type=EXECUTABLE/",
+          "group": "1_targetActions@3"
         },
         {
           "command": "cmake.outline.launchTarget",
-          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet",
-          "group": "bookmarkActions@3"
+          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet && viewItem =~ /type=EXECUTABLE/",
+          "group": "1_targetActions@4"
+        },
+        {
+          "command": "cmake.outline.revealInCMakeLists",
+          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet && viewItem =~ /isDefault=/ && viewItem =~ /canBuild=true|canRun=true/",
+          "group": "1_targetActions@5"
+        },
+        {
+          "command": "cmake.outline.setDefaultTarget",
+          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet && viewItem =~ /canRun=true|canBuild=true/ && viewItem =~ /isDefault=false/",
+          "group": "2_targetState@1"
+        },
+        {
+          "command": "cmake.outline.setLaunchTarget",
+          "when": "view == cmake.bookmarks && cmake:enableFullFeatureSet && viewItem =~ /type=EXECUTABLE/ && viewItem =~ /isLaunch=false/",
+          "group": "2_targetState@2"
         }
       ],
       "editor/title/context": [

src/extension.ts

@@ -2654,9 +2654,24 @@ async function setup(context: vscode.ExtensionContext, progress?: ProgressHandle
                 return runCommand('launchTarget', target.folder, target.name, target.sourceDir);
             }
         }),
-        vscode.commands.registerCommand('cmake.outline.setDefaultTarget', (what: TargetNode) => runCommand('setDefaultTarget', what.folder, what.name, what.sourceDir)),
-        vscode.commands.registerCommand('cmake.outline.setLaunchTarget', (what: TargetNode) => runCommand('selectLaunchTarget', what.folder, what.name, what.sourceDir)),
-        vscode.commands.registerCommand('cmake.outline.revealInCMakeLists', (what: TargetNode) => what.openInCMakeLists()),
+        vscode.commands.registerCommand('cmake.outline.setDefaultTarget', (what: TargetNode | BookmarkNode) => {
+            const target = resolveTargetNode(what);
+            if (target) {
+                return runCommand('setDefaultTarget', target.folder, target.name, target.sourceDir);
+            }
+        }),
+        vscode.commands.registerCommand('cmake.outline.setLaunchTarget', (what: TargetNode | BookmarkNode) => {
+            const target = resolveTargetNode(what);
+            if (target) {
+                return runCommand('selectLaunchTarget', target.folder, target.name, target.sourceDir);
+            }
+        }),
+        vscode.commands.registerCommand('cmake.outline.revealInCMakeLists', (what: TargetNode | BookmarkNode) => {
+            const target = resolveTargetNode(what);
+            if (target) {
+                return target.openInCMakeLists();
+            }
+        }),
         vscode.commands.registerCommand('cmake.outline.runTest', (what: CTestTestNode) => runCommand('runTest', what.folder, what.testName, what.sourceDir)),
         vscode.commands.registerCommand('cmake.outline.debugTest', (what: CTestTestNode) => runCommand('debugCTest', what.folder, what.testName, what.sourceDir)),
         vscode.commands.registerCommand('cmake.outline.compileFile', (what: SourceFileNode) => runCommand('compileFile', what.filePath)),

src/ui/bookmarks.ts

@@ -46,7 +46,24 @@ export class BookmarkNode extends BaseNode {
             this.bookmark.projectName || localize('not.available', 'N/A'),
             this.bookmark.type,
             this.bookmark.folderName);
-        item.contextValue = `nodeType=bookmark;type=${this.bookmark.type};bookmarked=true`;
+
+        // Build contextValue. For TARGET bookmarks with a live source node, propagate
+        // target metadata (canBuild, canRun, isDefault, isLaunch, specific type) so
+        // that the same context-menu actions available in the outline also appear here.
+        if (this.bookmark.type === 'TARGET' && this.bookmark.sourceNode instanceof TargetNode) {
+            const sourceItem = this.bookmark.sourceNode.getTreeItem();
+            const sourceContext = sourceItem.contextValue || '';
+            item.contextValue = sourceContext
+                .replace(/nodeType=target/, 'nodeType=bookmark')
+                + ',bookmarked=true';
+        } else if (this.bookmark.type === 'TARGET') {
+            // Unresolved target bookmark — include default flags so the contextValue
+            // structure is consistent but no actions that require a live node will match.
+            item.contextValue = 'nodeType=bookmark,type=TARGET,bookmarked=true,canBuild=false,canRun=false,isDefault=false,isLaunch=false';
+        } else {
+            item.contextValue = `nodeType=bookmark,type=${this.bookmark.type},bookmarked=true`;
+        }
+
         item.iconPath = new vscode.ThemeIcon("bookmark");
         return item;
     }