Skip to content

Commit c8ff2ef

Browse files
Copilotsnehara99
andauthored
Fix CMake script path links not working in CHS/CSY/FRA/PLK locales (#4700)
* Initial plan * Fix CMake script path links not working in CHS/CSY/FRA/PLK locales Co-authored-by: snehara99 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: snehara99 <[email protected]>
1 parent 4aa8c7f commit c8ff2ef

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ Features:
77

88
Bug Fixes:
99

10+
- Fix CMake script path links not working in CHS/CSY/FRA/PLK locales due to localized quotes. [#4383](https://github.com/microsoft/vscode-cmake-tools/issues/4383)
1011
- Fix user-level tasks defined in `~/.config/Code/User/tasks.json` causing infinite spinner. [#4659](https://github.com/microsoft/vscode-cmake-tools/pull/4659)
1112
- Fix "Copy Value" in CMake debugger copying variable name instead of value. [#4551](https://github.com/microsoft/vscode-cmake-tools/issues/4551)
1213
- cmakeDriver: Fixes getCompilerVersion by using compilerPath instead of compilerName. [#4647](https://github.com/microsoft/vscode-cmake-tools/pull/4647) [@lygstate](https://github.com/lygstate)

src/debug/cmakeDebugger/debuggerScriptDriver.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export async function executeScriptWithDebugger(scriptPath: string, scriptArgs:
4343
concreteArgs.push(debuggerInformation.dapLog);
4444
}
4545

46-
cmakeLogger.info(localize('run.script', "Executing CMake script: \"{0}\"", scriptPath));
46+
cmakeLogger.info(localize('run.script', "Executing CMake script: {0}", scriptPath));
4747

4848
const env = EnvironmentUtils.merge([process.env, EnvironmentUtils.create(scriptEnv)]);
4949
const child = proc.execute(cmakeExe.path, concreteArgs, outputConsumer, { environment: env});
@@ -62,9 +62,9 @@ export async function executeScriptWithDebugger(scriptPath: string, scriptArgs:
6262

6363
const result = await child.result;
6464
if (result.retc === 0) {
65-
cmakeLogger.info(localize('run.script.successful', "CMake script: \"{0}\" completed successfully.", scriptPath));
65+
cmakeLogger.info(localize('run.script.successful', "CMake script: {0} completed successfully.", scriptPath));
6666
} else {
67-
cmakeLogger.info(localize('run.script.failed', "CMake script: \"{0}\" completed unsuccessfully.", scriptPath));
67+
cmakeLogger.info(localize('run.script.failed', "CMake script: {0} completed unsuccessfully.", scriptPath));
6868
throw new Error("HEY");
6969
}
7070
} else {

0 commit comments

Comments
 (0)