Fix user-level tasks.json causing infinite spinner (#4659)

* Fix user tasks.json not working - handle non-WorkspaceFolder task scopes

Co-authored-by: hanniavalera <[email protected]>

* Add null check to task.scope type guard

Co-authored-by: hanniavalera <[email protected]>

* Add CHANGELOG entry for v1.23 user tasks.json fix

Co-authored-by: hanniavalera <[email protected]>

* Fix CHANGELOG entry to link to PR #4659

Co-authored-by: hanniavalera <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: hanniavalera <[email protected]>

Author: Copilot

CHANGELOG.md

@@ -1,5 +1,11 @@
 # What's New?
 
+## 1.23
+
+Bug Fixes:
+
+- Fix user-level tasks defined in `~/.config/Code/User/tasks.json` causing infinite spinner. [#4659](https://github.com/microsoft/vscode-cmake-tools/pull/4659)
+
 ## 1.22
 
 Features:

src/cmakeTaskProvider.ts

@@ -228,9 +228,10 @@ export class CMakeTaskProvider implements vscode.TaskProvider {
         const execution: any = task.execution;
         if (!execution) {
             const definition: CMakeTaskDefinition = <any>task.definition;
-            // In this extension, the scope of the task is always a workspace folder.
-            const workspaceFolder: vscode.WorkspaceFolder = task.scope as vscode.WorkspaceFolder;
-            const resolvedTask: CMakeTask = new vscode.Task(definition, workspaceFolder, definition.label, CMakeTaskProvider.CMakeSourceStr,
+            // task.scope can be a WorkspaceFolder, TaskScope.Global, or TaskScope.Workspace.
+            // Only use it as a WorkspaceFolder if it's an object (not a number or null).
+            const workspaceFolder: vscode.WorkspaceFolder | undefined = (task.scope && typeof task.scope === 'object') ? task.scope as vscode.WorkspaceFolder : undefined;
+            const resolvedTask: CMakeTask = new vscode.Task(definition, workspaceFolder ?? vscode.TaskScope.Workspace, definition.label, CMakeTaskProvider.CMakeSourceStr,
                 new vscode.CustomExecution(async (resolvedDefinition: vscode.TaskDefinition): Promise<vscode.Pseudoterminal> =>
                     new CustomBuildTaskTerminal(resolvedDefinition.command, resolvedDefinition.targets, workspaceFolder, resolvedDefinition.preset, resolvedDefinition.options)
                 ), []);
@@ -243,9 +244,10 @@ export class CMakeTaskProvider implements vscode.TaskProvider {
         const execution: any = task.execution;
         if (!execution) {
             const definition: CMakeTaskDefinition = <any>task.definition;
-            // In this extension, the scope of the task is always a workspace folder.
-            const workspaceFolder: vscode.WorkspaceFolder = task.scope as vscode.WorkspaceFolder;
-            const resolvedTask: CMakeTask = new vscode.Task(definition, workspaceFolder, definition.label, CMakeTaskProvider.CMakeSourceStr,
+            // task.scope can be a WorkspaceFolder, TaskScope.Global, or TaskScope.Workspace.
+            // Only use it as a WorkspaceFolder if it's an object (not a number or null).
+            const workspaceFolder: vscode.WorkspaceFolder | undefined = (task.scope && typeof task.scope === 'object') ? task.scope as vscode.WorkspaceFolder : undefined;
+            const resolvedTask: CMakeTask = new vscode.Task(definition, workspaceFolder ?? vscode.TaskScope.Workspace, definition.label, CMakeTaskProvider.CMakeSourceStr,
                 new vscode.CustomExecution(async (resolvedDefinition: vscode.TaskDefinition): Promise<vscode.Pseudoterminal> =>
                     new CustomBuildTaskTerminal(resolvedDefinition.command, resolvedDefinition.targets, workspaceFolder, resolvedDefinition.preset, resolvedDefinition.options)
                 ), []);