cmakeDriver: Fixes getCompilerVersion by using compilerPath instead of compilerName (#4647)

* Dump stackTrace for failed proc::execute

It's for easily locate where failed when doing proc::execute

* cmakeDriver: Fixes getCompilerVersion by using compilerPath instead of compilerName

Closes: #3063

Signed-off-by: Yonggang Luo <[email protected]>

---------

Signed-off-by: Yonggang Luo <[email protected]>

Author: lygstate

CHANGELOG.md

@@ -8,6 +8,7 @@ Features:
 Bug Fixes:
 
 - Fix user-level tasks defined in `~/.config/Code/User/tasks.json` causing infinite spinner. [#4659](https://github.com/microsoft/vscode-cmake-tools/pull/4659)
+- cmakeDriver: Fixes getCompilerVersion by using compilerPath instead of compilerName. [#4647](https://github.com/microsoft/vscode-cmake-tools/pull/4647) [@lygstate](https://github.com/lygstate)
 
 ## 1.22
 

src/drivers/cmakeDriver.ts

@@ -1356,7 +1356,7 @@ export abstract class CMakeDriver implements vscode.Disposable {
         // since some compilers can output their version without a specific switch.
         let version;
         if (compiler?.versionOutputRegexp) {
-            version = await this.testCompilerVersion(compilerName, compilerDir, compiler?.versionSwitch, RegExp(compiler.versionOutputRegexp, "mgi"), compiler.captureGroup) || "unknown";
+            version = await this.testCompilerVersion(compilerPath, compilerDir, compiler?.versionSwitch, RegExp(compiler.versionOutputRegexp, "mgi"), compiler.captureGroup) || "unknown";
         } else {
             version = "unknown";
         }

src/proc.ts

@@ -166,6 +166,8 @@ export function execute(command: string, args?: string[], outputConsumer?: Outpu
         options.environment,
         options.overrideLocale ? localeOverride : {}]);
 
+    const stackTrace = new Error().stack;
+
     const cmdstr = buildCmdStr(command, args);
     if (options && options.silent !== true) {
         log.info(// We do simple quoting of arguments with spaces.
@@ -234,23 +236,23 @@ export function execute(command: string, args?: string[], outputConsumer?: Outpu
         let stderr_acc = '';
         let stderr_line_acc = '';
         child?.on('error', err => {
-            log.warning(localize({key: 'process.error', comment: ['The space before and after all placeholders should be preserved.']}, 'The command: {0} failed with error: {1}', `${cmdstr}`, `${err}`));
+            log.warning(localize({key: 'process.error', comment: ['The space before and after all placeholders should be preserved.']}, 'The command: {0} failed with error: {1} stack: {2}', `${cmdstr}`, `${err}`, `${stackTrace}`));
         });
         child?.on('exit', (code, signal) => {
             if (code !== 0) {
                 if (signal !== null && signal !== undefined) {
-                    log.warning(localize({key: 'process.exit.with.signal', comment: ['The space before and after all placeholders should be preserved.']}, 'The command: {0} exited with code: {1} and signal: {2}', `${cmdstr}`, `${code}`, `${signal}`));
+                    log.warning(localize({key: 'process.exit.with.signal', comment: ['The space before and after all placeholders should be preserved.']}, 'The command: {0} exited with code: {1} and signal: {2} stack: {3}', `${cmdstr}`, `${code}`, `${signal}`, `${stackTrace}`));
                 } else {
-                    log.warning(localize({key: 'process.exit', comment: ['The space before and after all placeholders should be preserved.']}, 'The command: {0} exited with code: {1}', `${cmdstr}`, `${code}`));
+                    log.warning(localize({key: 'process.exit', comment: ['The space before and after all placeholders should be preserved.']}, 'The command: {0} exited with code: {1} stack: {2}', `${cmdstr}`, `${code}`, `${stackTrace}`));
                 }
                 if (options?.showOutputOnError) {
                     if (stdout_acc) {
                         const output = stdout_acc.trimEnd().replace(/\n/g, '\n\t');
-                        log.warning(localize('process.exit.stdout', 'Command output on standard out: {0}', `${output}`));
+                        log.warning(localize('process.exit.stdout', 'Command output on standard out: {0} stack: {1}', `${output}`, `${stackTrace}`));
                     }
                     if (stderr_acc) {
                         const output = stderr_acc.trimEnd().replace(/\n/g, '\n\t');
-                        log.warning(localize('process.exit.stderr', 'Command output on standard error: {0}', `${output}`));
+                        log.warning(localize('process.exit.stderr', 'Command output on standard error: {0} stack: {1}', `${output}`, `${stackTrace}`));
                     }
                 }
             }