Skip to content

Commit 21fa776

Browse files
Update release/1.19 (#4075)
* update node version, @vsce/vsce, and fix build errors from node updat… (#4055) * update node version, @vsce/vsce, and fix build errors from node update, add improved signing * update node in ci builds * update vscode engine * fix copy * don't sign vsix with VsixSha2 anymore * update changelog * xml2js cg (#4069) * xml2js cg * update tests as well * try update partial * switch kit? * ninja is added to path so it should work, still investigating * update action version with same tool versions * changes to test * test output * more testing * test macos-13 * remove logging * remove logging * try explicit macos-14 * go back to macos-13 * remove static version of vscode * need to use 13 * comment * update node (#4072) * ensure ready to release (#4074) * ensure ready to release * update third party * update workflows (#4076)
1 parent 406216a commit 21fa776

18 files changed

Lines changed: 1354 additions & 576 deletions

File tree

.github/workflows/build-vsix.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
- name: Setup Node.js environment
1919
uses: actions/[email protected]
2020
with:
21-
node-version: '16'
21+
node-version: '20'
2222
check-latest: true
2323

2424
- name: Get Short SHA

.github/workflows/ci-main-linux.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: CI (Linux)
22

33
on:
44
push:
5-
branches: [ main, rel ]
5+
branches: [ main, 'release/**' ]
66
pull_request:
7-
branches: [ main, rel ]
7+
branches: [ main, 'release/**' ]
88

99
jobs:
1010
build:
@@ -16,7 +16,7 @@ jobs:
1616
- name: Setup Node environment
1717
uses: actions/setup-node@v3
1818
with:
19-
node-version: 16
19+
node-version: 20
2020

2121
- name: Install Yarn
2222
run: npm install -g yarn
@@ -31,7 +31,10 @@ jobs:
3131
run: yarn lint
3232

3333
- name: Install CMake/Ninja
34-
uses: lukka/[email protected]
34+
uses: lukka/[email protected]
35+
with:
36+
cmakeVersion: 3.18.3
37+
ninjaVersion: 1.10.1
3538

3639
- name: Build fake compilers for tests
3740
uses: urkle/[email protected]

.github/workflows/ci-main-mac.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,21 +2,21 @@ name: CI (macOS)
22

33
on:
44
push:
5-
branches: [ main, rel ]
5+
branches: [ main, 'release/**' ]
66
pull_request:
7-
branches: [ main, rel ]
7+
branches: [ main, 'release/**']
88

99
jobs:
1010
build:
11-
runs-on: macos-latest
11+
runs-on: macos-13 # TODO: This is a workaround until macos-14 is fixed: https://github.com/actions/runner-images/issues/10624
1212

1313
steps:
1414
- uses: actions/checkout@v3
1515

1616
- name: Setup Node environment
1717
uses: actions/setup-node@v3
1818
with:
19-
node-version: 16
19+
node-version: 20
2020

2121
- name: Install Yarn
2222
run: npm install -g yarn
@@ -31,7 +31,10 @@ jobs:
3131
run: yarn lint
3232

3333
- name: Install CMake/Ninja
34-
uses: lukka/[email protected]
34+
uses: lukka/[email protected]
35+
with:
36+
cmakeVersion: 3.18.3
37+
ninjaVersion: 1.10.1
3538

3639
- name: Build fake compilers for tests
3740
uses: urkle/[email protected]

.github/workflows/ci-main.win.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: CI (Windows)
22

33
on:
44
push:
5-
branches: [ main, rel ]
5+
branches: [ main, 'release/**' ]
66
pull_request:
7-
branches: [ main, rel ]
7+
branches: [ main, 'release/**' ]
88

99
jobs:
1010
build:
@@ -17,7 +17,7 @@ jobs:
1717
- name: Setup Node environment
1818
uses: actions/setup-node@v3
1919
with:
20-
node-version: 16
20+
node-version: 20
2121

2222
- name: Install Yarn
2323
run: npm install -g yarn
@@ -33,7 +33,10 @@ jobs:
3333

3434
# The cmake server mode has been removed since CMake 3.20
3535
- name: Install CMake/Ninja
36-
uses: lukka/[email protected]
36+
uses: lukka/[email protected]
37+
with:
38+
cmakeVersion: 3.18.3
39+
ninjaVersion: 1.10.1
3740

3841
- name: Build fake compilers for tests
3942
uses: urkle/[email protected]

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,15 @@
11
# What's New?
22

3+
## 1.19.52
4+
5+
Improvements:
6+
7+
- Update signing to support VSCode extension signing. [#4055](https://github.com/microsoft/vscode-cmake-tools/pull/4055)
8+
39
## 1.19.51
410

11+
Bug Fixes:
12+
513
- Fix generator and preferredGenerator logic. [#4031](https://github.com/microsoft/vscode-cmake-tools/issues/4031), [#4005](https://github.com/microsoft/vscode-cmake-tools/issues/4005), [#4032](https://github.com/microsoft/vscode-cmake-tools/issues/4032)
614

715
## 1.19.50

0 commit comments

Comments
 (0)