Skip to content

Commit 101158c

Browse files
Copilotsnehara99hanniavalera
authored
Fix build not revealing the output panel (respect cmake.revealLog) (#4887)
* Initial plan * Fix build not revealing output panel by adding log.showChannel() at start of build The build operation now respects the cmake.revealLog setting, matching the behavior of the configure step. PR #4759 had removed the unconditional showChannel call, but it should have been kept since the Logger.showChannel() method already checks the revealLog setting. Fixes #4885 Agent-Logs-Url: https://github.com/microsoft/vscode-cmake-tools/sessions/5d3e410f-38fa-4fb7-864a-b53e48c9cde9 Co-authored-by: snehara99 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: snehara99 <[email protected]> Co-authored-by: Hannia Valera <[email protected]>
1 parent f70c14a commit 101158c

2 files changed

Lines changed: 2 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ Bug Fixes:
7272
- Fix configure/build sometimes using stale preset values when unsaved changes to included preset files are auto-saved before configure. The extension now explicitly refreshes presets from disk after saving, instead of relying solely on the asynchronous file watcher. [#4502](https://github.com/microsoft/vscode-cmake-tools/issues/4502)
7373
- Fix overly aggressive preset reloading on every build/debug/launch. Preset reapplication now only runs when `cmake.configureOnEdit` is enabled and preset files had unsaved changes, instead of unconditionally re-reading all preset files. [#4792](https://github.com/microsoft/vscode-cmake-tools/issues/4792)
7474
- Reduce overly verbose logging when CMake configure or build fails. The Output panel no longer floods with duplicated output, and the channel is only revealed on error rather than unconditionally. [#4749](https://github.com/microsoft/vscode-cmake-tools/issues/4749)
75+
- Fix building a target no longer revealing the output panel. The build now respects the `cmake.revealLog` setting to show the output channel at the start of a build. [#4885](https://github.com/microsoft/vscode-cmake-tools/issues/4885)
7576
- Fix Test Results panel not hyperlinking file paths for GoogleTest failures. The default `cmake.ctest.failurePatterns` now includes a pattern matching GoogleTest's `file:line: Failure` output format. [#4589](https://github.com/microsoft/vscode-cmake-tools/issues/4589)
7677
- Fix wrong path created for artifact when parsing code model using CMake File API. [#3015](https://github.com/microsoft/vscode-cmake-tools/issues/3015)
7778
- Fix garbled characters (Mojibake) in the Output panel when MSVC outputs UTF-8 (e.g., with `/utf-8`) on non-UTF-8 Windows systems. When `cmake.outputLogEncoding` is `auto`, the build output is now validated as UTF-8 before falling back to the system code page. [#4520](https://github.com/microsoft/vscode-cmake-tools/issues/4520)

src/cmakeProject.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2245,6 +2245,7 @@ export class CMakeProject {
22452245
*/
22462246
async runBuild(targets?: string[], showCommandOnly?: boolean, taskConsumer?: proc.OutputConsumer, isBuildCommand?: boolean, cancellationToken?: vscode.CancellationToken): Promise<CommandResult> {
22472247
if (!showCommandOnly) {
2248+
log.showChannel();
22482249
log.info(localize('run.build', 'Building folder: {0}', await this.binaryDir || this.folderName), (targets && targets.length > 0) ? targets.join(', ') : '');
22492250
}
22502251
let drv: CMakeDriver | null;

0 commit comments

Comments
 (0)