docs: document parseInstances behavior change for missing InstanceName

dlevy-msft-sql · dlevy-msft-sql · commit b5053d1f6362 · 2026-04-24T15:52:47.000-05:00
diff --git a/pkg/sqlcmd/serverlist.go b/pkg/sqlcmd/serverlist.go
@@ -107,7 +107,9 @@ func parseInstances(msg []byte) msdsn.BrowserData {
 					if len(instanceDict) == 0 {
 						break
 					}
-					// Only add if InstanceName key exists and is non-empty
+				// Deliberate behavior change from go-mssqldb's parseInstances:
+				// skip entries with missing or empty InstanceName (e.g. malformed
+				// registry data) instead of adding them under an empty key.
 					if instName, ok := instanceDict["InstanceName"]; ok && instName != "" {
 						results[strings.ToUpper(instName)] = instanceDict
 					}

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,9 @@ func parseInstances(msg []byte) msdsn.BrowserData {`
`107`	`107`	`if len(instanceDict) == 0 {`
`108`	`108`	`break`
`109`	`109`	`}`
`110`		`- // Only add if InstanceName key exists and is non-empty`
	`110`	`+ // Deliberate behavior change from go-mssqldb's parseInstances:`
	`111`	`+ // skip entries with missing or empty InstanceName (e.g. malformed`
	`112`	`+ // registry data) instead of adding them under an empty key.`
`111`	`113`	`if instName, ok := instanceDict["InstanceName"]; ok && instName != "" {`
`112`	`114`	`results[strings.ToUpper(instName)] = instanceDict`
`113`	`115`	`}`