Add float64/float32 formatting to match ODBC sqlcmd behavior

Co-authored-by: dlevy-msft-sql <[email protected]>

Author: Copilot

modern

@@ -9,6 +9,7 @@ import (
 	"errors"
 	"fmt"
 	"io"
+	"strconv"
 	"strings"
 	"time"
 
@@ -530,6 +531,14 @@ func (f *sqlCmdFormatterType) scanRow(rows *sql.Rows) ([]string, error) {
 				} else {
 					row[n] = "0"
 				}
+			case float64:
+				// Format float64 to match ODBC sqlcmd behavior
+				// Use 'f' format with -1 precision to avoid scientific notation
+				// and to show all significant digits
+				row[n] = strconv.FormatFloat(x, 'f', -1, 64)
+			case float32:
+				// Format float32 to match ODBC sqlcmd behavior
+				row[n] = strconv.FormatFloat(float64(x), 'f', -1, 32)
 			default:
 				var err error
 				if row[n], err = fmt.Sprintf("%v", x), nil; err != nil {

pkg/sqlcmd/format.go

@@ -158,3 +158,39 @@ func TestFormatterXmlMode(t *testing.T) {
 	assert.NoError(t, err, "runSqlCmd returned error")
 	assert.Equal(t, `<sys.databases name="master"/>`+SqlcmdEol, buf.buf.String())
 }
+
+func TestFormatterFloatFormatting(t *testing.T) {
+	// Test that float formatting matches ODBC sqlcmd behavior
+	// This addresses the issue where go-sqlcmd was using scientific notation
+	// while ODBC sqlcmd uses decimal notation
+	s, buf := setupSqlCmdWithMemoryOutput(t)
+	defer buf.Close()
+	
+	// Test query with float values from the issue
+	query := `SELECT 
+		CAST(788991.19988463481 AS FLOAT) as Longitude1,
+		CAST(4713347.3103808956 AS FLOAT) as Latitude1,
+		CAST(789288.40771771886 AS FLOAT) as Longitude2,
+		CAST(4712632.075629076 AS FLOAT) as Latitude2,
+		CAST(788569.36558582436 AS FLOAT) as Longitude3,
+		CAST(4714608.0418091472 AS FLOAT) as Latitude3`
+	
+	err := runSqlCmd(t, s, []string{query, "GO"})
+	assert.NoError(t, err, "runSqlCmd returned error")
+	
+	output := buf.buf.String()
+	
+	// Verify that the output contains decimal notation, not scientific notation
+	// Scientific notation would look like "4.713347310380896e+06"
+	// Decimal notation should look like "4713347.3103808956"
+	assert.NotContains(t, output, "e+", "Output should not contain scientific notation (e+)")
+	assert.NotContains(t, output, "E+", "Output should not contain scientific notation (E+)")
+	
+	// Verify that specific expected values are present (allowing for precision differences)
+	assert.Contains(t, output, "788991.1998846", "Output should contain decimal representation of Longitude1")
+	assert.Contains(t, output, "4713347.310380", "Output should contain decimal representation of Latitude1")
+	assert.Contains(t, output, "789288.4077177", "Output should contain decimal representation of Longitude2")
+	assert.Contains(t, output, "4712632.075629", "Output should contain decimal representation of Latitude2")
+	assert.Contains(t, output, "788569.3655858", "Output should contain decimal representation of Longitude3")
+	assert.Contains(t, output, "4714608.041809", "Output should contain decimal representation of Latitude3")
+}