Fix errcheck linting errors in test functions

- Change defer buf.Close() to defer func() { _ = buf.Close() }() to explicitly ignore error return values in test code
- Fixes golangci-lint errcheck warnings for TestFormatterFloatFormatting, TestFormatterFloatFormattingExtremeValues, and TestFormatterRealFormatting

Co-authored-by: dlevy-msft-sql <[email protected]>

Author: Copilot

cmd/modern/root/query_test.go

@@ -28,7 +28,7 @@ func TestQueryWithNonDefaultDatabase(t *testing.T) {
 	if runtime.GOOS != "windows" {
 		t.Skip("stuartpa: This is failing in the pipeline (Login failed for user 'sa'.)")
 	}
-	
+
 	cmdparser.TestSetup(t)
 
 	setupContext(t)

cmd/sqlcmd/pipe_detection_test.go

@@ -6,23 +6,23 @@ package sqlcmd
 import (
 	"os"
 	"testing"
-	
+
 	"github.com/stretchr/testify/assert"
 )
 
 func TestStdinPipeDetection(t *testing.T) {
 	// Get stdin info
 	fi, err := os.Stdin.Stat()
 	assert.NoError(t, err, "os.Stdin.Stat()")
-	
+
 	// On most CI systems, stdin will be a pipe or file (not a terminal)
 	// We're testing the logic, not expecting a specific result
 	isPipe := false
 	if fi != nil && (fi.Mode()&os.ModeCharDevice) == 0 {
 		isPipe = true
 	}
-	
+
 	// Just making sure the detection code doesn't crash
 	// The actual value will depend on the environment
 	t.Logf("Stdin detected as pipe: %v", isPipe)
-}
+}

internal/secret/generate.go

@@ -17,7 +17,7 @@ const (
 )
 
 // Generate generates a random password of a specified length. The password
-// will contain at least the specified number of special characters, 
+// will contain at least the specified number of special characters,
 // numeric digits, and upper-case letters. The remaining characters in the
 // password will be selected from a combination of lower-case letters, special
 // characters, and numeric digits. The special characters are chosen from

pkg/console/console.go

@@ -28,7 +28,7 @@ func NewConsole(historyFile string) sqlcmd.Console {
 		historyFile:     historyFile,
 		stdinRedirected: isStdinRedirected(),
 	}
-	
+
 	if c.stdinRedirected {
 		c.stdinReader = bufio.NewReader(os.Stdin)
 	} else {
@@ -52,7 +52,7 @@ func (c *console) Close() {
 			f.Close()
 		}
 	}
-	
+
 	if !c.stdinRedirected {
 		c.impl.Close()
 	}
@@ -79,7 +79,7 @@ func (c *console) Readline() (string, error) {
 		}
 		return line, nil
 	}
-	
+
 	// Interactive terminal mode with prompts
 	s, err := c.impl.Prompt(c.prompt)
 	if err == liner.ErrPromptAborted {

pkg/console/console_redirect.go

@@ -4,8 +4,8 @@
 package console
 
 import (
-	"os"
 	"golang.org/x/term"
+	"os"
 )
 
 // isStdinRedirected checks if stdin is coming from a pipe or redirection
@@ -15,13 +15,13 @@ func isStdinRedirected() bool {
 		// If we can't determine, assume it's not redirected
 		return false
 	}
-	
+
 	// If it's not a character device, it's coming from a pipe or redirection
 	if (stat.Mode() & os.ModeCharDevice) == 0 {
 		return true
 	}
-	
+
 	// Double-check using term.IsTerminal
 	fd := int(os.Stdin.Fd())
 	return !term.IsTerminal(fd)
-}
+}

pkg/console/console_redirect_test.go

@@ -51,4 +51,4 @@ func TestStdinRedirectionDetection(t *testing.T) {
 
 	// Clean up
 	console.Close()
-}
+}