Get rid of NodeCheckFlags.InCheckIdentifier

Author: Andarist

src/compiler/checker.ts

@@ -30866,23 +30866,18 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                 const parent = declaration.parent.parent;
                 const rootDeclaration = getRootDeclaration(parent);
                 if (rootDeclaration.kind === SyntaxKind.VariableDeclaration && getCombinedNodeFlagsCached(rootDeclaration) & NodeFlags.Constant || rootDeclaration.kind === SyntaxKind.Parameter) {
-                    const links = getNodeLinks(parent);
-                    if (!(links.flags & NodeCheckFlags.InCheckIdentifier)) {
-                        links.flags |= NodeCheckFlags.InCheckIdentifier;
-                        const parentType = getTypeForBindingElementParent(parent, CheckMode.Normal);
-                        const parentTypeConstraint = parentType && mapType(parentType, getBaseConstraintOrType);
-                        links.flags &= ~NodeCheckFlags.InCheckIdentifier;
-                        if (parentTypeConstraint && parentTypeConstraint.flags & TypeFlags.Union && !(rootDeclaration.kind === SyntaxKind.Parameter && isSomeSymbolAssigned(rootDeclaration))) {
-                            const pattern = declaration.parent;
-                            const narrowedType = getFlowTypeOfReference(pattern, parentTypeConstraint, parentTypeConstraint, /*flowContainer*/ undefined, location.flowNode);
-                            if (narrowedType.flags & TypeFlags.Never) {
-                                return neverType;
-                            }
-                            // Destructurings are validated against the parent type elsewhere. Here we disable tuple bounds
-                            // checks because the narrowed type may have lower arity than the full parent type. For example,
-                            // for the declaration [x, y]: [1, 2] | [3], we may have narrowed the parent type to just [3].
-                            return getBindingElementTypeFromParentType(declaration, narrowedType, /*noTupleBoundsCheck*/ true);
+                    const parentType = getTypeForBindingElementParent(parent, CheckMode.Normal);
+                    const parentTypeConstraint = parentType && mapType(parentType, getBaseConstraintOrType);
+                    if (parentTypeConstraint && parentTypeConstraint.flags & TypeFlags.Union && !(rootDeclaration.kind === SyntaxKind.Parameter && isSomeSymbolAssigned(rootDeclaration))) {
+                        const pattern = declaration.parent;
+                        const narrowedType = getFlowTypeOfReference(pattern, parentTypeConstraint, parentTypeConstraint, /*flowContainer*/ undefined, location.flowNode);
+                        if (narrowedType.flags & TypeFlags.Never) {
+                            return neverType;
                         }
+                        // Destructurings are validated against the parent type elsewhere. Here we disable tuple bounds
+                        // checks because the narrowed type may have lower arity than the full parent type. For example,
+                        // for the declaration [x, y]: [1, 2] | [3], we may have narrowed the parent type to just [3].
+                        return getBindingElementTypeFromParentType(declaration, narrowedType, /*noTupleBoundsCheck*/ true);
                     }
                 }
             }

src/compiler/types.ts

@@ -6240,8 +6240,7 @@ export const enum NodeCheckFlags {
     ConstructorReference                     = 1 << 29,  // Binding to a class constructor inside of the class's body.
     ContainsClassWithPrivateIdentifiers      = 1 << 20,  // Marked on all block-scoped containers containing a class with private identifiers.
     ContainsSuperPropertyInStaticInitializer = 1 << 21,  // Marked on all block-scoped containers containing a static initializer with 'super.x' or 'super[x]'.
-    InCheckIdentifier                        = 1 << 22,
-    PartiallyTypeChecked                     = 1 << 23,  // Node has been partially type checked
+    PartiallyTypeChecked                     = 1 << 22,  // Node has been partially type checked
 
     /** These flags are LazyNodeCheckFlags and can be calculated lazily by `hasNodeCheckFlag` */
     LazyFlags = SuperInstance