Merge branch 'main' into main

Author: dontwanttothink

.github/copilot-instructions.md

@@ -15,13 +15,13 @@ npx hereby local             # Build the compiler into built/local
 npx hereby clean             # Delete the built compiler  
 npx hereby tests             # Build the test infrastructure
 npx hereby runtests          # Run all tests
-npx hereby runtests-parallel # Run tests in parallel (recommended)
+npx hereby runtests-parallel # Run tests in parallel 🚨 MANDATORY BEFORE FINISHING!
 npx hereby runtests --runner=fourslash # Run only fourslash tests
 npx hereby runtests --runner=compiler # Run only compiler tests
 npx hereby runtests --tests=<testPath> # Run specific test
 npx hereby baseline-accept   # Accept new test baselines
-npx hereby lint              # Run eslint
-npx hereby format            # Run code formatting
+npx hereby lint              # Run eslint 🚨 MANDATORY BEFORE FINISHING!
+npx hereby format            # Run code formatting 🚨 MANDATORY BEFORE FINISHING!
 ```
 
 ## Fourslash Test Syntax Guide
@@ -258,10 +258,22 @@ npx hereby runtests --tests=tests/cases/fourslash/completion*.ts
 
 ## Important Guidelines
 
+### 🚨 CRITICAL: Before Finishing Your Work 🚨
+
+**THESE STEPS ARE MANDATORY BEFORE COMMITTING/PUSHING ANY CHANGES:**
+
+1. **MUST RUN:** `npx hereby runtests-parallel` (even though it takes 10-15 minutes)
+2. **MUST RUN:** `npx hereby lint` and fix ALL lint issues
+3. **MUST RUN:** `npx hereby format` as the final step
+
+**❌ PRs that fail these checks will be rejected without review.**
+
 ### Keeping Things Tidy
 
-- Once you think you're done, run `npx hereby lint` and fix any issues
-- Then always run `npx hereby format` as your last step
+- You can assume lint, tests, and formatting are clean on a fresh clone
+- Only run these verification steps AFTER making changes to code
+- Run `npx hereby lint` and fix ALL issues after making changes
+- Run `npx hereby format` as your final step after making changes
 
 ### Test Locations
 
@@ -317,11 +329,14 @@ When fixing bugs or implementing features, follow this workflow:
    - Once you've got the basics figured out, enhance your test to cover edge cases and other variations
    - Run the test again and commit the baseline diff along with the test edit
 
-5. **Run all other tests to ensure you didn't break anything**
-   - Run `npx hereby runtests-parallel` and wait for it to finish (10-15 minutes is normal!)
+5. **🚨 MANDATORY: Run all other tests to ensure you didn't break anything**
+   - **REQUIRED:** Run `npx hereby runtests-parallel` and wait for it to finish (10-15 minutes is normal!)
+   - **THIS STEP CANNOT BE SKIPPED** - patience is essential!
    - Some collateral baseline changes are normal, but review for correctness
    - Put these diffs in another commit
 
-6. **Always format and lint**
-   - Don't forget to run `npx hereby lint` and `npx hereby format` before you're done
+6. **🚨 MANDATORY: Lint and format your changes**
+   - **REQUIRED:** Run `npx hereby lint` and fix ALL issues
+   - **REQUIRED:** Run `npx hereby format` before you're done
+   - **YOU CANNOT FINISH WITHOUT THESE STEPS**
    - Double-check your line endings. Source files in this repo typically use CRLF line endings. Fix all line endings to be consistent before you wrap up

.github/workflows/ci.yml

@@ -95,7 +95,7 @@ jobs:
           name: coverage
           path: coverage
 
-      - uses: codecov/codecov-action@ad3126e916f78f00edff4ed0317cf185271ccc2d # v5.4.2
+      - uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 # v5.4.3
         with:
           use_oidc: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork) }}
           disable_search: true

.github/workflows/codeql.yml

@@ -46,7 +46,7 @@ jobs:
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
-        uses: github/codeql-action/init@45775bd8235c68ba998cffa5171334d58593da47 # v3.28.15
+        uses: github/codeql-action/init@39edc492dbe16b1465b0cafca41432d857bdb31a # v3.29.1
         with:
           config-file: ./.github/codeql/codeql-configuration.yml
         # Override language selection by uncommenting this and choosing your languages
@@ -56,7 +56,7 @@ jobs:
       # Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
       # If this step fails, then you should remove it and run the build manually (see below).
       - name: Autobuild
-        uses: github/codeql-action/autobuild@45775bd8235c68ba998cffa5171334d58593da47 # v3.28.15
+        uses: github/codeql-action/autobuild@39edc492dbe16b1465b0cafca41432d857bdb31a # v3.29.1
 
       # ℹ️ Command-line programs to run using the OS shell.
       # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
@@ -70,4 +70,4 @@ jobs:
       #     make release
 
       - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@45775bd8235c68ba998cffa5171334d58593da47 # v3.28.15
+        uses: github/codeql-action/analyze@39edc492dbe16b1465b0cafca41432d857bdb31a # v3.29.1

.github/workflows/nightly.yaml

@@ -30,7 +30,7 @@ jobs:
           # corepack enable npm
           npm install -g $(jq -r '.packageManager' < package.json)
           npm --version
-      - name: Setup and publish nightly
+      - name: Setup and test nightly
         run: |
           npm ci
           npx hereby configure-nightly

.github/workflows/scorecard.yml

@@ -34,7 +34,7 @@ jobs:
           persist-credentials: false
 
       - name: 'Run analysis'
-        uses: ossf/scorecard-action@f49aabe0b5af0936a0987cfb85d86b75731b0186 # v2.4.1
+        uses: ossf/scorecard-action@05b42c624433fc40578a4040d5cf5e36ddca8cde # v2.4.2
         with:
           results_file: results.sarif
           results_format: sarif
@@ -55,6 +55,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: 'Upload to code-scanning'
-        uses: github/codeql-action/upload-sarif@45775bd8235c68ba998cffa5171334d58593da47 # v3.28.15
+        uses: github/codeql-action/upload-sarif@39edc492dbe16b1465b0cafca41432d857bdb31a # v3.29.1
         with:
           sarif_file: results.sarif

.github/workflows/twoslash-repros.yaml

@@ -3,6 +3,8 @@ name: Twoslash Code Sample Repros
 on:
   schedule:
     - cron: '0 8 * * *'
+  repository_dispatch:
+    types: [run-twoslash-repros]
   workflow_dispatch:
     inputs:
       issue:

azure-pipelines.release-publish.yml

@@ -3,17 +3,25 @@ pr: none
 
 parameters:
   - name: _REMINDER
-    default: Review & undraft the release at https://github.com/microsoft/TypeScript/releases once it appears!
+    displayName: Review & undraft the release at https://github.com/microsoft/TypeScript/releases once it appears!
+    type: boolean
+    default: true
   - name: PUBLISH_TAG
+    displayName: npm publish tag
     default: dev
+    values:
+      - dev
+      - beta
+      - rc
+      - latest
   - name: RELEASE_TITLE_NAME
+    displayName: GitHub release title name
     default: 0.0.0 Test
   - name: TAG_NAME
+    displayName: Git tag name
     default: v0.0.0-SetMe
 
 variables:
-  - name: _REMINDER
-    value: ${{ parameters._REMINDER }}
   - name: PUBLISH_TAG
     value: ${{ parameters.PUBLISH_TAG }}
   - name: RELEASE_TITLE_NAME
@@ -47,11 +55,11 @@ extends:
         os: windows
 
     stages:
-      - stage: Stage_1
-        displayName: Publish tarball
+      - stage: Publish
+        displayName: Publish
         jobs:
-          - job: Job_1
-            displayName: Agent job
+          - job: tarball
+            displayName: Publish tarball
             condition: succeeded()
             timeoutInMinutes: 0
             templateContext:
@@ -66,29 +74,26 @@ extends:
             steps:
               - checkout: none
               - task: CmdLine@2
-                displayName: Rename versioned drop to typescript.tgz
+                displayName: Copy versioned drop to typescript.tgz
                 inputs:
                   script: |
                     pushd $(Pipeline.Workspace)/tgz
                     ls -lhR
-                    mv typescript-*.tgz typescript.tgz
+                    cp typescript-*.tgz typescript.tgz
               - task: Npm@1
                 displayName: npm publish tarball
                 inputs:
                   command: custom
                   workingDir: $(Pipeline.Workspace)/tgz
                   verbose: false
                   customCommand: publish $(Pipeline.Workspace)/tgz/typescript.tgz --tag $(PUBLISH_TAG)
-                  # This must match the service connection.
+                  # This must match the service connection name.
                   customEndpoint: Typescript NPM
                   publishEndpoint: Typescript NPM
 
-      - stage: Stage_2
-        displayName: Publish git tag
-        dependsOn: Stage_1
-        jobs:
-          - job: Job_1
-            displayName: Agent job
+          - job: github
+            displayName: Create github release
+            dependsOn: tarball
             condition: succeeded()
             timeoutInMinutes: 0
             templateContext:
@@ -104,20 +109,22 @@ extends:
               - task: GitHubRelease@1
                 displayName: GitHub release (create)
                 inputs:
-                  # This must match the service connection.
+                  # This must match the service connection name.
                   gitHubConnection: typescript-bot connection
                   repositoryName: microsoft/TypeScript
                   tagSource: userSpecifiedTag
                   tag: $(TAG_NAME)
                   title: TypeScript $(RELEASE_TITLE_NAME)
                   releaseNotesSource: inline
                   releaseNotesInline: |
+                    <!---
                     For release notes, check out the [release announcement]().
                     For new features, check out the [What's new in TypeScript $(TAG_NAME)]().
                     For the complete list of fixed issues, check out the
                     * [fixed issues query for TypeScript $(TAG_NAME)](https://github.com/microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.3%22+is%3Aclosed+).
                     Downloads are available on:
                     * [npm](https://www.npmjs.com/package/typescript)
+                    -->
                   assets: $(Pipeline.Workspace)/tgz/**/typescript-*.tgz
-                  isDraft: true
+                  isDraft: ${{ not(eq(parameters.PUBLISH_TAG, 'latest')) }}
                   addChangeLog: false