Remove hasTypeArguments

This internal utility function and corresponding type weren't in use,
and `hasTypeArguments`'s guarding was buggy:

- `node` could be a `NodeWithTypeArguments`, which is not a member of
  `HasTypeArguments`
- else branch narrowing was wrong: `typeArguments` is optional, so it
  can be undefined while `node` is assignable to `HasTypeArguments`

Author: mkantor

src/compiler/types.ts

@@ -1293,13 +1293,6 @@ export type HasIllegalTypeParameters =
     | SetAccessorDeclaration
     | GetAccessorDeclaration;
 
-export type HasTypeArguments =
-    | CallExpression
-    | NewExpression
-    | TaggedTemplateExpression
-    | JsxOpeningElement
-    | JsxSelfClosingElement;
-
 export type HasInitializer =
     | HasExpressionInitializer
     | ForStatement

src/compiler/utilities.ts

@@ -222,7 +222,6 @@ import {
     HasModifiers,
     hasProperty,
     HasType,
-    HasTypeArguments,
     HeritageClause,
     Identifier,
     identifierToKeywordKind,
@@ -4751,11 +4750,6 @@ export function getTypeParameterFromJsDoc(node: TypeParameterDeclaration & { par
     return typeParameters && find(typeParameters, p => p.name.escapedText === name);
 }
 
-/** @internal @knipignore */
-export function hasTypeArguments(node: Node): node is HasTypeArguments {
-    return !!(node as HasTypeArguments).typeArguments;
-}
-
 /** @internal */
 export const enum AssignmentKind {
     None,

tests/baselines/reference/api/typescript.d.ts

@@ -4392,7 +4392,6 @@ declare namespace ts {
         | WhileStatement
         | WithStatement;
     type HasType = SignatureDeclaration | VariableDeclaration | ParameterDeclaration | PropertySignature | PropertyDeclaration | TypePredicateNode | ParenthesizedTypeNode | TypeOperatorNode | MappedTypeNode | AssertionExpression | TypeAliasDeclaration | JSDocTypeExpression | JSDocNonNullableType | JSDocNullableType | JSDocOptionalType | JSDocVariadicType;
-    type HasTypeArguments = CallExpression | NewExpression | TaggedTemplateExpression | JsxOpeningElement | JsxSelfClosingElement;
     type HasInitializer = HasExpressionInitializer | ForStatement | ForInStatement | ForOfStatement | JsxAttribute;
     type HasExpressionInitializer = VariableDeclaration | ParameterDeclaration | BindingElement | PropertyDeclaration | PropertyAssignment | EnumMember;
     type HasDecorators = ParameterDeclaration | PropertyDeclaration | MethodDeclaration | GetAccessorDeclaration | SetAccessorDeclaration | ClassExpression | ClassDeclaration;